Reword "we"s to "I"s for consistency #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

edolstra merged 1 commit into NixOS:master from kili-ilo:patch-1

Nov 4, 2021

Contributor

kili-ilo commented Nov 4, 2021

This script uses multiple forms of the first-person POV:

"We" to refer to the Nix team (

nix/scripts/install-multi-user.sh

Line 72 in 1e7c796

echo "We'd love to help if you need it."

)
"We" to refer to the combination of the installation script & the user/executor (

nix/scripts/install-multi-user.sh

Line 710 in 1e7c796

echo " Alright! We have our first nix at $NIX_INSTALLED_NIX"

)
"We" to refer to the installation script alone (

nix/scripts/install-multi-user.sh

Line 602 in 1e7c796

2. Show you what we are going to install and where. Then we will ask

)
"I" to refer to the installation script alone (

nix/scripts/install-multi-user.sh

Line 200 in 1e7c796

_textout "$RED" "Sorry, I didn't understand. I can only understand answers of y or n"

)

Since I prefer POV 4 to POV 3, this changes all instances of POV 3 to POV 4.


          Reword "we"s to "I"s for consistency

7d56174

This script uses multiple forms of the first-person POV:
1. "We" to refer to the Nix team (https://github.com/NixOS/nix/blob/1e7c796e66a692cd097b155bd0a60fedf20d554f/scripts/install-multi-user.sh#L72)
2. "We" to refer to the combination of the installation script & the user/executor (https://github.com/NixOS/nix/blob/1e7c796e66a692cd097b155bd0a60fedf20d554f/scripts/install-multi-user.sh#L710)
3. "We" to refer to the installation script alone (https://github.com/NixOS/nix/blob/1e7c796e66a692cd097b155bd0a60fedf20d554f/scripts/install-multi-user.sh#L602)
4. "I" to refer to the installation script alone (https://github.com/NixOS/nix/blob/1e7c796e66a692cd097b155bd0a60fedf20d554f/scripts/install-multi-user.sh#L200)

Since I prefer POV 4 to POV 3, this changes all instances of POV 3 to POV 4.

edolstra merged commit 3f447bc into NixOS:master

Member

edolstra commented Nov 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet