Conversation
|
This is tested and working. Let me know if anything needs to be done |
|
0xda157
left a comment
There was a problem hiding this comment.
the bin seems to be fully working
|
Changed as requested, thanks. Let me know if there's anything else |
|
|
The makefile should be patched to allow any CC. For example, on Darwin where clang is the default: |
565a5d8 to
d2ad079
Compare
|
Package still builds and works. One thing though, the maintainer put 0.2.2 instead of 0.2.1 here so the built program says it's version 0.2.2 |
|
Hmm.. it seems the program still lacks basic functionality. For example, the flag |
|
Yeah you're right hmm. Not very useful like this |
The application supports printing matches now |
|
Still looks buggy, e.g. |
|
Yeah tests fail too: |
|
I have released version 0.3.4 which should fix the reported bugs. Thanks again for the feedback. |
|
Version 0.3.4 passes tests and seems to work fine. Match printing (or tracking?) is a little slow but not too bad. |
yes I am working to improve speed on all architectures. Thanks! |
https://github.com/davidesantangelo/krep is a search tool, similar to grep.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.