Merged
Conversation
Member
|
I understood that Darwin builds are not sandboxed properly so trusted users should be extra careful when invoking ofBorg.
… and opening a PR not marked as WIP might also invoke ofBorg without an explicit request.
</pointless-nitpick>
This is just a nitpick about the wording of the list of caveats, in case it ever gets linked from outside as an example of a list of caveats.
|
Mic92
approved these changes
Nov 18, 2018
Contributor
Author
|
Thanks Graham |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Politely asking 😺
it would allow me to check Linux+Darwin package updates before merging into nixpkgs.
I understood that Darwin builds are not sandboxed properly so trusted users should be extra careful when invoking ofBorg.
I also keep in mind that builders have limited resources and that I should check https://monitoring.nix.ci before launching a potentially heavy job.
/cc @grahamc @LnL7 @Mic92