configure.ac: add check for strip #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, "make check" fails on Ubuntu 20.04 because the STRIP variable is not set in the resulting tests/Makefile: """ git clone https://github.com/NixOS/patchelf.git ./bootstrap.sh ./configure make VERBOSE=1 check ... gcc -fPIC -shared -o libbig-dynstr.so big-dynstr.c only-keep-debug libbig-dynstr.so -o libbig-dynstr.debug /bin/bash: only-keep-debug: command not found make[2]: [Makefile:1526: libbig-dynstr.debug] Error 127 (ignored) ... FAIL: no-dynamic-section.sh =========================== patchelf: getting info about 'libbig-dynstr.debug': No such file or directory FAIL no-dynamic-section.sh (exit status: 1) """ strip is used by the regression testsuite, so add a check for it configure.ac. Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, "make check" fails on Ubuntu 20.04 because the STRIP variable is not
set in the resulting tests/Makefile:
strip is used by the regression testsuite, so add a check for it configure.ac.
Signed-off-by: Ovidiu Panait ovpanait@gmail.com
Thank you!
Please do your best to include a regression test
so that the quality of future releases can be preserved.