Refactor nix code a bit to have regular package.nix
#603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
package.nix
branch
2 times, most recently
from
6d6cbbb to
c2e2aad
Compare
Let's just call it by its conventional name, now.
Ericson2314
force-pushed
the
package.nix
branch
from
c2e2aad to
3fa865c
Compare
This is too opinionated for the package itself, which is supposed to be very open-ended about how something it is built. It should instead go with the `NIX_CFLAGS_COMPILE = "-static"` that it is supposed to enable.
Ericson2314
force-pushed
the
package.nix
branch
from
3fa865c to
baf3530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #602