Skip to content

[FIX] Flaky Dask testing#623

Merged
nasaul merged 5 commits intomainfrom
fix/test_errors
Apr 17, 2026
Merged

[FIX] Flaky Dask testing#623
nasaul merged 5 commits intomainfrom
fix/test_errors

Conversation

@nasaul
Copy link
Copy Markdown
Contributor

@nasaul nasaul commented Apr 15, 2026

There are flaky tests in tests/test_distributed_forecast.py. For example, see here

Digging deeper this is a known error on LightGBM with Dask.

Until LigthGBM fixes this behaviour, I've added a re-run trigger in the pytest configuration to stop the random failures in the testing suite.

Had to disable rerunfailures in CI.yaml due to conflicts with valgrind.

@elessar-for-github
Copy link
Copy Markdown

Changes made by this pull request:

pyproject.toml
[Error processing diff]

uv.lock
[Error processing diff]

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fix/test_errors (a72107b) with main (104dd43)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (6e66d2f) during the generation of this report, so 104dd43 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@nasaul nasaul merged commit 11e99df into main Apr 17, 2026
25 checks passed
@nasaul nasaul deleted the fix/test_errors branch April 17, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants