fix(tree-walker): LocalDependencyTreeLoader fails resolving symlink l…#746
Merged
Conversation
🦋 Changeset detectedLatest commit: e07ba86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ErwanRaulo
force-pushed
the
fix/treewalker-tests
branch
from
July 21, 2026 21:14
c371b70 to
3d98954
Compare
fraxken
approved these changes
Jul 21, 2026
clemgbld
approved these changes
Jul 22, 2026
Member
|
CI doesn't look happy ^^ |
ErwanRaulo
force-pushed
the
fix/treewalker-tests
branch
from
July 22, 2026 18:34
3d98954 to
52b28c7
Compare
should be more reliable by not testing files coming from npm registry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug
LocalDependencyTreeLoader.load() was failing on macOS by returning an empty dependency tree.
cause:
On macOS, os.tmpdir() returns /var/folders/..., which is a symlink to /private/var/folders/...
consequence:
two root nodes in the Arborist inventory, the incorrect one of which was referenced by arb.actualTree.
why this fix?
The only place where realpath should be used is in LocalDependencyTreeLoader, which communicates with Arborist. it is responsible for ensuring path consistency.