Remove without_storage_info for the grants pallet V2 #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
+ Coverage 89.41% 89.74% +0.32%
==========================================
Files 34 33 -1
Lines 6234 6238 +4
==========================================
+ Hits 5574 5598 +24
+ Misses 660 640 -20
Continue to review full report at Codecov.
|
simonsso
suggested changes
Jul 13, 2022
Contributor
simonsso
left a comment
simonsso
left a comment
There was a problem hiding this comment.
The bot is complaining about new code is not covered by tests, is there something we could do in this regard?
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
…de/chain into shamb0/v2_bounded_grants
…de/chain into shamb0/v2_bounded_grants
simonsso
reviewed
Jul 13, 2022
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
…de/chain into shamb0/v2_bounded_grants
… into shamb0/v2_bounded_grants
Co-authored-by: Alex Sedighi <alex@nodle.co>
Use the latest release of paritytech/srtool
* remove without_storage_info Signed-off-by: R.Rajeshkumar <rajesh@nodle.com> * Update pallets/allocations/src/lib.rs Co-authored-by: Fredrik Simonsson <simson@thesimson.net> * Update pallets/allocations/src/lib.rs Co-authored-by: Fredrik Simonsson <simson@thesimson.net> * Update pallets/allocations/src/lib.rs Co-authored-by: Fredrik Simonsson <simson@thesimson.net> * Fix to CI/CD build try-runtime error Signed-off-by: R.Rajeshkumar <rajesh@nodle.com> * Fix to CI/CD build try-runtime error (#637) * chore: prepare for releasing 2.0.21 (#638) * remove without_storage_info Signed-off-by: R.Rajeshkumar <rajesh@nodle.com> * Update pallets/allocations/src/lib.rs Co-authored-by: Fredrik Simonsson <simson@thesimson.net> * Update pallets/allocations/src/lib.rs Co-authored-by: Fredrik Simonsson <simson@thesimson.net> * Update pallets/allocations/src/lib.rs Co-authored-by: Fredrik Simonsson <simson@thesimson.net> * Update pallets/allocations/src/lib.rs Co-authored-by: Alex Sedighi <alex@nodle.co> * Update pallets/allocations/src/lib.rs Co-authored-by: Alex Sedighi <alex@nodle.co> * intake review suggestions Signed-off-by: R.Rajeshkumar <rajesh@nodle.com> Co-authored-by: R.Rajeshkumar <rajesh@nodle.com> Co-authored-by: Fredrik Simonsson <simson@thesimson.net> Co-authored-by: Alex Sedighi <alex@nodle.co>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
aliXsed
reviewed
Jul 20, 2022
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
…de/chain into shamb0/v2_bounded_grants
Contributor
Author
|
Replaced by PR #642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #173
HighLights
VestingSchedulesis moved to bounded vector.VestingSchedulesis Configured viaMaxSchedule.MaxScheduleOverflow.TODO
Ready for Intake Review