#821 Migrate PhotoCapture component#1
Draft
NoelDeMartin wants to merge 1 commit into
Draft
Conversation
This is a first pass towards modernizing this component, but it can still be improved further to use newer patterns, such as: - Using the InputTrait for form participation - Using the new Dialog system - Using the new convention for custom events using the `solid-ui-` prefix. Also removed some inline comments about attribution, leaving them here for documentation purposes: > The original code was written by Sir Tim Berners-Lee. It was made into a web component by AI Model GPT-5.4 > > Prompt: Take the code from src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass towards modernizing this component, but it can still be improved further to use newer patterns, such as:
solid-ui-prefix.Also removed some inline comments about attribution, leaving them here for documentation purposes: