Skip to content

Conversation

@alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented May 7, 2025

Mostly copied from #6496, except that that PR is based off a commit before the eslint upgrade, and has some merge conflicts.

This also doesn't disable the support for Node 22, it just adds Node 24.

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 0d5696f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

hardhat

Total size of the bundle: 226M
Total number of dependencies (including transitive): 113

List of dependencies (sorted by size)
220M	total
24M	@ignored/edr-optimism-linux-x64-musl
24M	@ignored/edr-optimism-linux-x64-gnu
22M	@ignored/edr-optimism-win32-x64-msvc
21M	@ignored/edr-optimism-linux-arm64-musl
21M	@ignored/edr-optimism-linux-arm64-gnu
20M	esbuild
18M	@ignored/edr-optimism-darwin-x64
17M	@ignored/edr-optimism-darwin-arm64
7.7M	@opentelemetry/semantic-conventions
6.2M	@sentry/core
4.5M	@sentry/node
3.1M	@opentelemetry/api
2.6M	zod
2.5M	micro-eth-signer
2.3M	@opentelemetry/core
1.9M	@opentelemetry/resources
1.9M	@noble/curves
1.7M	undici
1.6M	@opentelemetry/sdk-trace-base
1.2M	@noble/hashes
956K	@opentelemetry/instrumentation
888K	@sentry/opentelemetry
864K	@streamparser/json
860K	@nomicfoundation/hardhat-utils
760K	@opentelemetry/api-logs
692K	import-in-the-middle
624K	resolve
624K	micro-packed
588K	minimatch
584K	tsx
576K	acorn
544K	fast-equals
536K	@nomicfoundation/hardhat-errors
492K	@scure/bip39
408K	json-stream-stringify
368K	ethereum-cryptography
348K	@ignored/edr
332K	@streamparser/json-node
320K	pg-protocol
320K	enquirer
304K	@ignored/edr-optimism
300K	@opentelemetry/instrumentation-http
288K	semver
224K	@opentelemetry/instrumentation-pg
212K	@opentelemetry/instrumentation-graphql
200K	undici-types
196K	ws
188K	@opentelemetry/instrumentation-mongodb
180K	@opentelemetry/instrumentation-undici
176K	@opentelemetry/instrumentation-express
172K	@opentelemetry/instrumentation-amqplib
168K	@scure/base
164K	cjs-module-lexer
156K	@opentelemetry/instrumentation-hapi
148K	@opentelemetry/instrumentation-redis-4
148K	@opentelemetry/instrumentation-mysql
144K	@opentelemetry/instrumentation-fs
136K	get-tsconfig
136K	adm-zip
136K	@opentelemetry/instrumentation-koa
132K	@opentelemetry/instrumentation-knex
124K	@opentelemetry/instrumentation-mongoose
124K	@opentelemetry/instrumentation-ioredis
120K	@opentelemetry/instrumentation-mysql2
120K	@opentelemetry/instrumentation-connect
116K	@opentelemetry/instrumentation-kafkajs
112K	@opentelemetry/instrumentation-tedious
112K	@opentelemetry/context-async-hooks
96K	@scure/bip32
96K	@opentelemetry/instrumentation-dataloader
92K	chalk
80K	@opentelemetry/instrumentation-generic-pool
76K	pg-types
76K	@prisma/instrumentation
72K	@nomicfoundation/solidity-analyzer
68K	debug
68K	@opentelemetry/sql-common
68K	@opentelemetry/instrumentation-lru-memoizer
64K	@nomicfoundation/hardhat-zod-utils
60K	acorn-import-attributes
60K	@opentelemetry/redis-common
56K	rfdc
56K	is-core-module
56K	function-bind
52K	@types/tedious
48K	shimmer
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
40K	require-in-the-middle
40K	forwarded-parse
40K	@types/mysql
36K	supports-preserve-symlinks-flag
36K	p-map
36K	@types/pg
32K	hasown
28K	xtend
28K	brace-expansion
24K	strip-ansi
24K	postgres-interval
24K	postgres-array
24K	env-paths
24K	ansi-regex
20K	postgres-date
20K	postgres-bytea
20K	pg-int8
20K	path-parse
20K	ms
20K	module-details-from-path
20K	balanced-match
20K	@types/shimmer
20K	@types/pg-pool
20K	@types/connect

@alcuadrado
Copy link
Member Author

alcuadrado commented May 7, 2025

The node-test-reporter integration tests can't run with multiple versions of Node, as they depend on the behavior of it. The reason is that they are snapshot tests, and they will fail as soon as there's a version change. We should either make them support multiple snapshots, or run them only on a single version.

On top of that, we analyzed the failures a bit with @galargh, and realized that tests now are printed as failures when their subtests fail, even if the test itself passes. That behavior should be re-evaluated, as the subtest failure was already reported, so it looks weird and unnecessary. Maybe we shouldn't show the failures of tests (as opossed to suites) when it's just because of subtests.

@alcuadrado
Copy link
Member Author

The node-test-reporter integration tests can't run with multiple versions of Node, as they depend on the behavior of it. The reason is that they are snapshot tests, and they will fail as soon as there's a version change. We should either make them support multiple snapshots, or run them only on a single version.

On top of that, we analyzed the failures a bit with @galargh, and realized that tests now are printed as failures when their subtests fail, even if the test itself passes. That behavior should be re-evaluated, as the subtest failure was already reported, so it looks weird and unnecessary.

@iosh this looks like the kind of issue that you may be interested in

@kanej kanej requested review from kanej and removed request for kanej May 19, 2025 09:23
@kanej kanej mentioned this pull request Jun 3, 2025
2 tasks
@kanej kanej added the no changeset needed This PR doesn't require a changeset label Jun 9, 2025
@kanej kanej added this pull request to the merge queue Jun 9, 2025
Merged via the queue into v-next with commit d1002d2 Jun 9, 2025
243 checks passed
@kanej kanej deleted the v-next-node24 branch June 9, 2025 11:22
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Jun 9, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changeset needed This PR doesn't require a changeset

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants