Skip to content

Fixes #28139: Installing plugin is a common operation and should be visible in the plugins page#6952

Open
P4uline wants to merge 14 commits intoNormation:branches/rudder/9.0from
P4uline:enh_28139/installing_plugin_is_a_common_operation_and_should_be_visible_in_the_plugins_page
Open

Fixes #28139: Installing plugin is a common operation and should be visible in the plugins page#6952
P4uline wants to merge 14 commits intoNormation:branches/rudder/9.0from
P4uline:enh_28139/installing_plugin_is_a_common_operation_and_should_be_visible_in_the_plugins_page

Conversation

@P4uline
Copy link
Copy Markdown
Contributor

@P4uline P4uline commented Feb 26, 2026

https://issues.rudder.io/issues/28139

Refactoring step are in separeted commits to facilitate the code review.

  • reorganize plugins header block: inline displaySelectAll, put filters radio button on a new line, inline displayFilters method
  • move warning message line under filters div otherwise it shifts the filters div when it appears and disapears and makes a bad visual effect and adjust positionning with margin-top
  • fix font size: use default font size variable and fix the value
  • use rem unit because it's relative to document root value
  • format code

…s_a_common_operation_and_should_be_visible_in_the_plugins_page
…ld be visible in the plugins page

Fixes #28139: Installing plugin is a common operation and should be visible in the plugins page
@P4uline
Copy link
Copy Markdown
Contributor Author

P4uline commented Apr 10, 2026

PR updated with a new commit

@P4uline
Copy link
Copy Markdown
Contributor Author

P4uline commented Apr 15, 2026

Commit modified
reorganize plugins header block: inline displaySelectAll, put filters radio button on a new line

@P4uline P4uline force-pushed the enh_28139/installing_plugin_is_a_common_operation_and_should_be_visible_in_the_plugins_page branch 2 times, most recently from bfdc72d to ed467d0 Compare April 15, 2026 08:58
@P4uline
Copy link
Copy Markdown
Contributor Author

P4uline commented Apr 15, 2026

Commit modified
reorganize plugins header block: inline displaySelectAll, put filters radio button on a new line

@P4uline P4uline force-pushed the enh_28139/installing_plugin_is_a_common_operation_and_should_be_visible_in_the_plugins_page branch from ed467d0 to fbf6a37 Compare April 15, 2026 09:02
P4uline added 6 commits April 15, 2026 11:38
…ilters div when it appears and disapears and makes a bad visual effect and adjust positionning with margin-top
…size - use rem unit because it's relative to document root value
@P4uline P4uline marked this pull request as ready for review April 15, 2026 13:59
Copy link
Copy Markdown
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as we did this in mob, since commits are split, it needs a rebase before merging !

@P4uline
Copy link
Copy Markdown
Contributor Author

P4uline commented Apr 16, 2026

LGTM as we did this in mob, since commits are split, it needs a rebase before merging !

What would be the behavior of the bot if you approuve before the rebase ?

@clarktsiory
Copy link
Copy Markdown
Contributor

clarktsiory commented Apr 17, 2026

@P4uline it would merge the PR 😅
I'm not sure there is something else than "Draft status" to guarantee that the PR won't be merged by the bot, once it is approved (maybe the "Can't merge" label, but IIRC it still happened sometimes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants