Fixes #28139: Installing plugin is a common operation and should be visible in the plugins page#6952
Conversation
…isible in the plugins page
…s_a_common_operation_and_should_be_visible_in_the_plugins_page
…isible in the plugins page
…isible in the plugins page
…ld be visible in the plugins page Fixes #28139: Installing plugin is a common operation and should be visible in the plugins page
|
PR updated with a new commit |
…isible in the plugins page
|
Commit modified |
bfdc72d to
ed467d0
Compare
|
Commit modified |
… radio button on a new line
ed467d0 to
fbf6a37
Compare
…ilters div when it appears and disapears and makes a bad visual effect and adjust positionning with margin-top
…efault; and removing the extra button
…size - use rem unit because it's relative to document root value
clarktsiory
left a comment
There was a problem hiding this comment.
LGTM as we did this in mob, since commits are split, it needs a rebase before merging !
What would be the behavior of the bot if you approuve before the rebase ? |
|
@P4uline it would merge the PR 😅 |
https://issues.rudder.io/issues/28139
Refactoring step are in separeted commits to facilitate the code review.