Surface theme drop-in parse errors as startup notices - #111
Merged
Conversation
A malformed .forge/themes/*.toml (e.g. a truncated hex color) was silently dropped by ThemeRegistry, so a custom theme could vanish from the picker with no indication why. load_with_diagnostics now collects a message per file that fails to parse, and TuiApp::new surfaces them through the existing startup-notices banner.
mohitranka
force-pushed
the
theme/file-based-registry
branch
from
August 1, 2026 10:18
e071eb6 to
3a58bff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.forge/themes/*.toml(e.g. a truncated hex color) was silently dropped byThemeRegistry::loadwith zero indication why — the theme just vanished from the picker.ThemeRegistry::loadnow delegates to a newload_with_diagnostics, which collects a human-readable message for each drop-in file that fails to parse.TuiApp::newthreads those messages into the existing startup-notices banner, so a badtheme.tomlis now reported instead of silently skipped.Test plan
cargo test -p forge-tui(670 passed, including newinvalid_drop_in_is_skipped_but_reportedregression test)cargo clippy -p forge-tui --all-targetscargo fmt -p forge-tui -- --check