Fix dark theme regressions from the Forge Midnight recolor - #112
Merged
Conversation
The recolor in 37e4292 set accent and user_gutter_active to the same value, broke a WCAG AA contrast check for dim text on raised surfaces, and left three tests asserting stale hex literals from the old palette. - Give user_gutter_active its own lighter tint so it stays visually distinct from the submitted-message accent color. - Brighten text_muted slightly so dim-on-panel_alt clears 4.5:1 contrast. - Update test literals (background snapshot, drop-in override target, broken-toml corruption target) to track the new palette.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
37e4292("Update the dark theme") broke CI on main:accentanduser_gutter_activecollapsed to the same sage color,dimtext onpanel_altdropped below WCAG AA contrast (4.36:1), and three tests still asserted hex literals from the pre-recolor palette.user_gutter_activeits own lighter tint (#A3C7BC) so it stays visually distinct from the submitted-message accent color.text_muted(#8A877D→#908D83) sodimonpanel_altclears 4.5:1 contrast.Test plan
cargo test -p forge-tui --lib theme— all theme tests passcargo test -p forge-tui --lib— full crate suite, 670 passedcargo fmt --check -p forge-tui— clean