chore: drop the DCO sign-off checkbox from the PR template#190
Merged
Conversation
The convention was never enforced (no DCO check in CI) and the merged history doesn't follow it — most commits on main carry no Signed-off-by trailer. Apache-2.0 §5 already provides the inbound=outbound license grant for contributions, so the checkbox only generated false review blocks on external PRs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8EYHtUpzTX6YGfEXPRPKF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Removes the "Commits are signed off —
git commit -s(we use the DCO)" checkbox from.github/pull_request_template.md.The convention was never actually enforced — there is no DCO check in CI,
CONTRIBUTING.mddoesn't mention it, and the merged history doesn't follow it (the large majority of commits on main carry noSigned-off-bytrailer). In practice the checkbox only produced false review blocks on external PRs (#170, #188, #189) while providing no real provenance guarantee. Apache-2.0 §5 already gives the inbound=outbound license grant for submitted contributions.Closes # — (no issue; owner-directed cleanup)
Checklist
bun run preflightpasses — N/A, template-only change, no code paths touchedmanifest.json,shared/channel-config.js)Notes for reviewers
If DCO enforcement is ever genuinely wanted, the right shape is the DCO GitHub App as a required check — mechanical from day one — rather than an honor-system checkbox.
🤖 Generated with Claude Code
https://claude.ai/code/session_01L8EYHtUpzTX6YGfEXPRPKF
Generated by Claude Code