Skip to content

Harden reviewer trust, fetch egress, and narrow sidebars - #355

Merged
NotASithLord merged 4 commits into
mainfrom
codex/small-issues-swarm
Aug 8, 2026
Merged

Harden reviewer trust, fetch egress, and narrow sidebars#355
NotASithLord merged 4 commits into
mainfrom
codex/small-issues-swarm

Conversation

@NotASithLord

Copy link
Copy Markdown
Owner

Summary

  • fence saved-App search results and re-check reviewer grants against the live read-only policy at dispatch
  • inspect fetch_url header names, header values, and request bodies for off-origin exfiltration while preserving same-origin and ordinary-request behavior
  • make the Firefox-width sidebar deliberate: visible authority controls, named top-bar actions, and stale model-option response protection
  • add a live engine-tab forgery probe for P0-2 remainder: per-run MessagePorts, and actor/abort takes a runId from any first-party sender #308 item 1, whose exact service-worker sender pin is already present on current main

Regression and red-team coverage

  • expands the generated red-team report from 148 to 152 hostile probes: persistent saved-App prompt injection, header/body exfiltration, and actor-command replay
  • adds unit coverage for stale reviewer grants, App result fencing, malformed/cyclic request shapes, array-shaped headers, and the model picker’s A → B → A request race
  • adds browser-level sender-forgery and narrow-sidebar states, including eight viewport widths, native Tab order, accessibility-tree names, hit targets, overflow, and light/dark renders

Verification

  • adversarial review swarm: all three scoped reviews clean after two stale comments were corrected
  • bun test ./tests: 5,083 passed
  • bun run red-team: 11/11 scenarios, 152/152 hostile probes blocked
  • in-browser suite: 791 passed
  • bun run e2e:verify: 50 states, 202/202 checks
  • lint, strict typecheck, and diff checks clean
  • packaged preview verified in Firefox 153 at a real 310×900 sidebar viewport; controls and surrounding states rendered without horizontal overflow

Closes #236
Closes #270
Closes #335
Relates #308

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

The UI renders differently than the committed baselines — 18 of 46 screens changed (before ⟶ after below).

Empty chatidle-unlocked · up to 7.68% changed

dark — 7.68% of pixels (before ⟶ after)

Empty chat dark before/after

light — 6.61% of pixels (before ⟶ after)

Empty chat light before/after

Completed turncompleted-turn · up to 1.61% changed

dark — 1.61% of pixels (before ⟶ after)

Completed turn dark before/after

light — 1.61% of pixels (before ⟶ after)

Completed turn light before/after

Plan modemode-plan · up to 1.61% changed

dark — 1.61% of pixels (before ⟶ after)

Plan mode dark before/after

light — 1.60% of pixels (before ⟶ after)

Plan mode light before/after

Goal runninggoal-running · up to 1.83% changed

dark — 1.83% of pixels (before ⟶ after)

Goal running dark before/after

light — 1.70% of pixels (before ⟶ after)

Goal running light before/after

Failed turnerror-turn · up to 1.61% changed

dark — 1.61% of pixels (before ⟶ after)

Failed turn dark before/after

light — 1.61% of pixels (before ⟶ after)

Failed turn light before/after

Multi-turnmulti-turn-transcript · up to 1.61% changed

dark — 1.61% of pixels (before ⟶ after)

Multi-turn dark before/after

light — 1.61% of pixels (before ⟶ after)

Multi-turn light before/after

Thinkingbusy-thinking · up to 1.61% changed

dark — 1.61% of pixels (before ⟶ after)

Thinking dark before/after

light — 1.61% of pixels (before ⟶ after)

Thinking light before/after

Chatssessions-list · up to 1.06% changed

dark — 1.06% of pixels (before ⟶ after)

Chats dark before/after

light — 1.06% of pixels (before ⟶ after)

Chats light before/after

Tool calltool-card-expanded · up to 1.61% changed

dark — 1.61% of pixels (before ⟶ after)

Tool call dark before/after

light — 1.61% of pixels (before ⟶ after)

Tool call light before/after

Full-res before/after/diff PNGs: download the visual-diff-… artifact.

Intended? Re-run this workflow on the branch with update_visual_baselines checked, then commit the fresh baselines/linux-x64/ and regenerate GALLERY.md with bun run gallery.

github-actions Bot added a commit that referenced this pull request Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Visual regression

No visual drift. Every state renders identically to the committed baselines.

📸 Browse the visual gallery — 46 baseline screens (light + dark) as of this commit.

@NotASithLord
NotASithLord merged commit dbab5ea into main Aug 8, 2026
19 checks passed
@NotASithLord
NotASithLord deleted the codex/small-issues-swarm branch August 8, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant