Close cold-start egress cancellation races - #373
Merged
Conversation
… SW start The denylist seed hydrates async at service-worker boot, and webFetch's getDenylist does a synchronous readiness check. A sw/web-fetch request (Notebook module fetch, VM egress) that raced a cold start was refused with DenylistPolicyUnavailableError instead of waiting - the packaged page boot job hit exactly this on main's #370 merge run (the same tree passed on the PR branch and locally). The engine route now awaits an injected awaitDenylistPolicy gate (requireDenylistPolicy(await denylistReady)) before any fetch work, so the race becomes a short wait while a genuinely failed hydration still refuses before any egress. The sync check inside getDenylist stays as the last-resort chokepoint for every other direct caller. Signed-off-by: Jonathan Bursztyn <jobur93@gmail.com>
…st arrival The remote-fetch stop probe slept a fixed 150ms after starting the run, then aborted - on a slow runner the abort landed before the resolver had even issued the slow fetch, so the fixture saw 0 requests instead of the in-flight cancel the test pins (CI hit this on the #372 branch run). The fixture now serves a status endpoint reporting how many slow-module requests have arrived, and the probe polls it through the same audited sw/web-fetch relay the resolver uses, aborting only once the request is on the wire. Single injected block (geckodriver gives each script a fresh sandbox, so cross-call state is not an option), and elapsedMs now measures abort to settled - the prompt-stop property - instead of including run setup. Signed-off-by: Jonathan Bursztyn <jobur93@gmail.com>
Visual regression✅ No visual drift. Every state renders identically to the committed baselines. 📸 Browse the visual gallery — 54 baseline screens (light + dark) as of this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This integrates the useful work from #372 while preserving Jonathan Bursztyn’s authorship. The overlapping Notebook polling commit is already on main.
Validation
bun test ./tests(5,688 tests)bun run typecheckbun run lintbun run check:tscheckbun run red-team