Conversation
Drop support for Java 7
… in DefaultArrayFormatter
Support nested arrays and circular references in DefaultArrayFormatter
* added initial support for multiple locales * attempting to fix broken build
This was referenced Feb 9, 2017
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0.1.0 the only thing that Verifier could do upon verification would be to assert that the verification passed and throw a
VerifierExceptionotherwise.This PR changes this behaviour only slightly. By default, the above is still what happens, however, consumers of Verifier can now tap into the reporting process of the verification if needed and even prevent an error from being thrown if they so desired. The main intention here is to simply allow consumers to configure and customize Verifier as much as possible and this was a key step towards that. This would could allow consumers to even log verifications, if they wanted to, pass/fail.
Following on the back of #11, custom
Reportersand evenReportExecutorare registered and loaded using Java's SPI.