ci: dedupe runs, simplify pre-commit, DRY build/deploy - #58
Merged
Conversation
1 task
…ify pre-commit - Extract shared MkDocs build steps into _build.yml (workflow_call) with optional upload-site input; build.yml and deploy.yml call it - Remove push: trigger from build.yml and precommit.yml to prevent duplicate CI runs when a branch PR is opened - Refactor deploy.yml into build + deploy jobs so the site artifact is built once and passed to the peaceiris publish step - Drop redundant `if: github.ref == 'refs/heads/main'` guard in deploy job - Simplify precommit.yml: drop fetch-depth, Resolve-change-range step, and --from-ref/--to-ref extra_args; run --all-files now that the backlog is clean - Fix SC2086 (unquoted $GITHUB_OUTPUT) caught by actionlint/shellcheck Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bakerboy448
force-pushed
the
ci/workflow-improvements
branch
from
July 21, 2026 21:58
adea1a3 to
a345251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four CI improvements in one PR.
build.ymlandprecommit.ymltriggered on bothpushandpull_request, so a branch push + PR ran each twice. Nowpull_request: [main]only. (Fork PRs were already single-run.)precommit.yml— the repo backlog is clean, so the ~25-line "resolve change range" shell (needed only to skip legacy violations) is removed;pre-commit/actionruns--all-filesby default. More robust (catches regressions in untouched files)._build.yml(workflow_call, optionalupload-site).build.ymlcalls it for PR validation;deploy.ymlcalls it (uploading thesiteartifact) then adeployjob downloads and publishes.if— dropped the always-trueif: github.ref == 'refs/heads/main'on the deploy step.Deploy safety: the Pages publish is byte-for-byte preserved —
checkout(git context for peaceiris) →download-artifact(the built./site) → unchangedpeaceiris/actions-gh-pages@v4with the samecname: notifiarr.wiki, token,publish_dir, and bot identity. actionlint passes on all four files.