Skip to content

fix(deps): Update dependency zod to v4 #808

Merged
sergiojoker11 merged 11 commits into
mainfrom
renovate/major-4-@notifycalshared-and-zod
Aug 2, 2025
Merged

fix(deps): Update dependency zod to v4 #808
sergiojoker11 merged 11 commits into
mainfrom
renovate/major-4-@notifycalshared-and-zod

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate Bot commented Jul 10, 2025

This PR contains the following updates:

Package Change Age Confidence
zod (source) ^3.25.6 -> ^4.0.0 age confidence

Release Notes

colinhacks/zod (zod)

v4.0.5

Compare Source

v4.0.4

Compare Source

v4.0.3

Compare Source

v4.0.2

Compare Source

v4.0.1

Compare Source

Commits:

v4.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added dependencies Pull requests that update a dependency file node npm labels Jul 10, 2025
@renovate renovate Bot enabled auto-merge (squash) July 10, 2025 00:11
@renovate renovate Bot added the npm label Jul 10, 2025
@renovate
Copy link
Copy Markdown
Author

renovate Bot commented Jul 10, 2025

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn Unknown env config "store". This will stop working in the next major version of npm.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @notifycal/shared@4.8.2
npm error Found: zod@4.0.5
npm error node_modules/zod
npm error   zod@"^4.0.0" from the root project
npm error   peerOptional zod@">=3.x" from @aws-lambda-powertools/parser@2.23.0
npm error   node_modules/@aws-lambda-powertools/parser
npm error     @aws-lambda-powertools/parser@"^2.14.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer zod@"3.25.76" from @notifycal/shared@4.8.2
npm error node_modules/@notifycal/shared
npm error   @notifycal/shared@"4.8.2" from the root project
npm error
npm error Conflicting peer dependency: zod@3.25.76
npm error node_modules/zod
npm error   peer zod@"3.25.76" from @notifycal/shared@4.8.2
npm error   node_modules/@notifycal/shared
npm error     @notifycal/shared@"4.8.2" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /runner/cache/others/npm/_logs/2025-07-11T02_49_06_065Z-eresolve-report.txt
npm error A complete log of this run can be found in: /runner/cache/others/npm/_logs/2025-07-11T02_49_06_065Z-debug-0.log

@renovate renovate Bot force-pushed the renovate/major-4-@notifycalshared-and-zod branch 3 times, most recently from d3f3dc2 to e98a216 Compare July 10, 2025 12:26
@dsiguero dsiguero disabled auto-merge July 10, 2025 19:59
@dsiguero
Copy link
Copy Markdown
Member

brace brace

@renovate renovate Bot enabled auto-merge (squash) July 10, 2025 22:07
@renovate renovate Bot force-pushed the renovate/major-4-@notifycalshared-and-zod branch from e98a216 to 0b44fe0 Compare July 11, 2025 02:49
@renovate
Copy link
Copy Markdown
Author

renovate Bot commented Jul 11, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@sergiojoker11
Copy link
Copy Markdown
Member

sergiojoker11 commented Jul 11, 2025

down to 9 type errors. I believe they all depend on the upgrade of this dependency aws-powertools/powertools-lambda-typescript#4160

Update: thay have done it. It only needs to be released.

@sergiojoker11
Copy link
Copy Markdown
Member

We need to revert Notifycal/.github-private#5 once the dep bump gets reenabled.

@renovate renovate Bot changed the title fix(deps): Update dependency zod to v4 fix(deps): Update dependency zod to v4 - abandoned Jul 11, 2025
@renovate
Copy link
Copy Markdown
Author

renovate Bot commented Jul 11, 2025

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@dsiguero dsiguero marked this pull request as draft July 11, 2025 13:14
auto-merge was automatically disabled July 11, 2025 13:14

Pull request was converted to draft

@sergiojoker11 sergiojoker11 force-pushed the renovate/major-4-@notifycalshared-and-zod branch from 3de6b74 to 99d8eb4 Compare August 1, 2025 19:12
Comment thread package.json Outdated
"@middy/core": "^6.0.0",
"@middy/http-cors": "^6.0.0",
"@notifycal/shared": "5.1.0",
"@notifycal/shared": "file:../shared/notifycal-shared-5.1.0.tgz",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventType: 'EmailToBeSentAttemptFailed' as const,
data: {
...event.data,
errorPayload: error
Copy link
Copy Markdown
Member

@sergiojoker11 sergiojoker11 Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading unmasked this bug somehow. Field errorPayload of type z.any() wasn't being set.

eventType: 'ActionableEventReminderAttemptFailed' as const,
data: {
...e.data,
providerErrorPayload: error
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here/ Upgrading unmasked this bug somehow. Field providerErrorPayload of type z.any() wasn't being set.

Comment thread src/model/Credits.ts Outdated
subscription: z.number({ coerce: coerced }),
topup: z.number({ coerce: coerced })
subscription: coerced ? z.coerce.number() : z.number(),
topup: coerced ? z.coerce.number() : z.number()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are truly retarded. They got rid of some nice shortcut/helper

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth creating a coercedNumberSchema somewhere in "utils"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sergiojoker11 sergiojoker11 force-pushed the renovate/major-4-@notifycalshared-and-zod branch from d477bc4 to b3ddc2e Compare August 1, 2025 20:01
@sergiojoker11 sergiojoker11 force-pushed the renovate/major-4-@notifycalshared-and-zod branch from b3ddc2e to 5d0e8be Compare August 1, 2025 20:06
Comment thread src/utils/datetime.ts
if (!data || !dt.isValid) {
context.addIssue({
code: z.ZodIssueCode.custom,
export function timezoneValidator(arg: TimeZone, ctx?: z.RefinementCtx): boolean {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have adapted this cause it was already in the code base but I t not being used

Comment thread src/model/Jwt.ts
.merge(identitySchema);
export const accessTokenPayloadSchema = tokenPayloadBaseSchema.merge(ourAccessTokenClaimsSchema);
.extend(identitySchema.shape);
export const accessTokenPayloadSchema = tokenPayloadBaseSchema.extend(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge -> extend

import z from 'zod';

// eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/explicit-module-boundary-types
export function dynamoDbStreamsSchema<TNewImageSchema extends z.ZodTypeAny, TConfig>(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you remember the "type isntantiation is too deep and possibly infinite"? It does not happen anymore so I extracted the duplicated code that bothered me so much

Comment thread src/utils/queryString.ts
): Promise<z.infer<typeof schema>> {
return promiseTry(() => {
const raw = queryStringToObject(objectToQueryString(queryStringFlatObject));
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed anymore apparently

dsiguero
dsiguero previously approved these changes Aug 2, 2025
@dsiguero dsiguero marked this pull request as ready for review August 2, 2025 10:03
@dsiguero dsiguero marked this pull request as draft August 2, 2025 10:03
@sergiojoker11 sergiojoker11 changed the title fix(deps): Update dependency zod to v4 - abandoned fix(deps): Update dependency zod to v4 Aug 2, 2025
@sergiojoker11 sergiojoker11 marked this pull request as ready for review August 2, 2025 10:53
@sergiojoker11 sergiojoker11 merged commit 1926e39 into main Aug 2, 2025
8 checks passed
@sergiojoker11 sergiojoker11 deleted the renovate/major-4-@notifycalshared-and-zod branch August 2, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file node npm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants