Bug Description
On current main, npm audit fix in the Hermes repo does not clear all browser-tools vulnerabilities.
After running npm audit fix, hermes doctor still reports browser tool vulnerabilities, and npm audit still shows:
@appium/logger
- nested
lodash vulnerability under node_modules/@appium/logger/node_modules/lodash
The remaining vulnerable path appears to come from the pinned browser dependency tree.
Evidence
package.json currently pins:
"agent-browser": "^0.13.0"
npm outdated --json shows:
{
"agent-browser": {
"current": "0.13.0",
"wanted": "0.13.0",
"latest": "0.25.4"
}
}
npm audit still reports the remaining lodash vulnerability through @appium/logger after npm audit fix has already been run.
Steps to Reproduce
- Clone current
main.
- Run
npm install.
- Run
npm audit fix.
- Run
npm audit or hermes doctor.
Expected Behavior
Either:
- browser tools pass
npm audit after the documented fix flow, or
- Hermes is updated to a newer
agent-browser version that removes the vulnerable transitive dependency chain, or
doctor gives a more precise message that the remaining issue requires a dependency bump rather than another npm audit fix.
Actual Behavior
doctor continues to recommend npm audit fix, but the remaining browser vulnerability persists after doing exactly that.
Environment
- Hermes repo:
main
- Observed on local install at commit
33ee7741
Bug Description
On current
main,npm audit fixin the Hermes repo does not clear all browser-tools vulnerabilities.After running
npm audit fix,hermes doctorstill reports browser tool vulnerabilities, andnpm auditstill shows:@appium/loggerlodashvulnerability undernode_modules/@appium/logger/node_modules/lodashThe remaining vulnerable path appears to come from the pinned browser dependency tree.
Evidence
package.jsoncurrently pins:npm outdated --jsonshows:{ "agent-browser": { "current": "0.13.0", "wanted": "0.13.0", "latest": "0.25.4" } }npm auditstill reports the remaining lodash vulnerability through@appium/loggerafternpm audit fixhas already been run.Steps to Reproduce
main.npm install.npm audit fix.npm auditorhermes doctor.Expected Behavior
Either:
npm auditafter the documented fix flow, oragent-browserversion that removes the vulnerable transitive dependency chain, ordoctorgives a more precise message that the remaining issue requires a dependency bump rather than anothernpm audit fix.Actual Behavior
doctorcontinues to recommendnpm audit fix, but the remaining browser vulnerability persists after doing exactly that.Environment
main33ee7741