Skip to content

fix(ci): resolve provider and cross-platform regressions#52

Closed
NovasPlace wants to merge 7 commits into
masterfrom
fix/ci-regressions-20260720
Closed

fix(ci): resolve provider and cross-platform regressions#52
NovasPlace wants to merge 7 commits into
masterfrom
fix/ci-regressions-20260720

Conversation

@NovasPlace

@NovasPlace NovasPlace commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Root causes

  • A CI-only unreachable Ollama dependency was “fixed” by silently switching configured providers to hash embeddings, violating the provider contract and changing vector semantics.
  • Windows wiki-manifest paths were validated with the runner host’s POSIX path rules.
  • Standalone unquoted absolute paths containing spaces were only partially redacted.

Changes

  • Restore explicit embedding-provider error and dimension failures; hash embeddings remain available only when selected by configuration.
  • Make the two PostgreSQL integration suites use deterministic 768-dimensional hash embeddings instead of a live Ollama endpoint.
  • Validate wiki manifest paths with the root’s path family and reject absolute, drive-relative, NUL, and traversal inputs across both separator styles.
  • Route unambiguous standalone absolute paths through schema-aware whole-path redaction while preserving commands and multiple-path strings.

Verification

  • npm run typecheck — passed
  • npm run build — passed
  • npm run lint:src — 0 errors, 7 baseline warnings
  • Focused correction, redactor, embedding-provider, migration-artifact, and supply-chain tests — passed
  • GitHub Actions PostgreSQL 14 matrix — passed, including full tests and backup/restore drill
  • GitHub Actions PostgreSQL 16 matrix — passed, including full tests and backup/restore drill
  • Supply-chain audit, license policy, SBOM, full-history secret scan, and dependency review — passed

@NovasPlace NovasPlace closed this Jul 20, 2026
@NovasPlace NovasPlace changed the title fix(ci): resolve remaining cross-platform regressions fix(ci): resolve provider and cross-platform regressions Jul 20, 2026
@NovasPlace NovasPlace reopened this Jul 20, 2026
Comment thread src/redactor.ts
);
if ((absolutePathStarts?.length ?? 0) > 1) return false;
if (/^[A-Za-z]:[\\/]/u.test(value) || value.startsWith('\\\\')) return true;
return /^\/(?:home|Users|root|var|opt|etc|tmp|usr|mnt|srv|data|www|private|Volumes|Library|Applications)(?:\/.+)+$/u.test(value);
Comment thread src/redactor.ts
);
if ((absolutePathStarts?.length ?? 0) > 1) return false;
if (/^[A-Za-z]:[\\/]/u.test(value) || value.startsWith('\\\\')) return true;
return /^\/(?:home|Users|root|var|opt|etc|tmp|usr|mnt|srv|data|www|private|Volumes|Library|Applications)(?:\/.+)+$/u.test(value);
@NovasPlace
NovasPlace marked this pull request as ready for review July 20, 2026 06:01
@NovasPlace NovasPlace closed this Jul 20, 2026
@NovasPlace
NovasPlace deleted the fix/ci-regressions-20260720 branch July 20, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants