Say what actually lands in the inbox - #166
Conversation
The empty state promised "reviews, and PR updates". Neither can happen: the six pr_* notification types are declared but nothing emits them, because the GitHub pull request sync is not built yet. Somebody reading inbox zero had no way to tell whether the product was broken or simply quiet. It now names what does arrive, and says plainly that your own actions do not, which is the part that surprises people. The audience builder excludes the actor by design, so somebody who assigns every issue in the workspace themselves correctly sees nothing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 6 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
Someone looked at an empty inbox and could not tell whether notifications were broken or the inbox was simply quiet. The empty state was part of the reason:
Reviews and PR updates cannot land there.
pr_review_requested,pr_review_submitted,pr_approved,pr_merged,pr_closedandpr_checks_failedare declared inNOTIFICATION_TYPES, but nothing inpackages/coreorpackages/servicesemits any of them, because the GitHub pull request sync is not built yet.What the inbox really does
Checked against production: 294 notifications exist, all delivered, across five people. The types that actually fire today are
issue_assigned,issue_status_changed,comment_created,comment_replied,mention,reactionandsubscription_activity.The surprising part, and the reason one workspace owner saw nothing at all, is that the actor is excluded from their own notifications.
dedupeAudience(groups, [principal.userId])inissue-service.tsdoes that deliberately, and it is right: you should not be told about work you just did yourself. But somebody who created and self-assigned 182 of their own issues, and who was the actor on all 294 notifications everyone else received, correctly ends up with an empty inbox and no explanation.The new copy names what arrives and states that plainly.
Not changed here
The "Pull requests" tab stays. It is scaffolding for the sync that is coming, and the six types already exist in the schema. Once that lands the tab populates and the copy should mention reviews again.
The eight declared-but-never-emitted notification types are tracked separately rather than fixed here.
Greptile Summary
The PR updates the inbox empty-state description to reflect the notifications users currently receive and clarify that actions performed by the user do not notify them.
Confidence Score: 5/5
The PR appears safe to merge because it only changes static inbox copy and introduces no actionable defect.
The revised description remains consistent with the current notification and actor-exclusion behavior, and the change does not affect application logic.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(inbox): describe what actually lands..." | Re-trigger Greptile