fix(layout): make breadcrumb ancestors navigable - #71
Conversation
Breadcrumb segments rendered as plain text with an unused href field. Extract a pure breadcrumbsFor builder that accumulates ancestor paths and marks each crumb navigable only when it resolves to a real route, then render those crumbs as Link. The current page and unrouted parents stay as text so no crumb links to a 404.
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Make breadcrumb ancestors clickable links that navigate, instead of plain text.
Evidence (
bun testinapps/web, the touched package):A crumb links only when its accumulated path resolves to a real route, so unrouted parents (
/team,/issue) and the current page stay text and nothing links to a 404. Live dev-server screenshot skipped:next devcurrently 500s on every route from an unrelated Turbopack + react-email/prettier module-externalization issue, present onmain.