Skip to content

fix(layout): make breadcrumb ancestors navigable - #71

Merged
pulkitxm merged 1 commit into
mainfrom
fix/breadcrumb-navigation
Jul 24, 2026
Merged

fix(layout): make breadcrumb ancestors navigable#71
pulkitxm merged 1 commit into
mainfrom
fix/breadcrumb-navigation

Conversation

@pulkitxm

Copy link
Copy Markdown
Member

Make breadcrumb ancestors clickable links that navigate, instead of plain text.

Evidence (bun test in apps/web, the touched package):

apps/web/src/lib/breadcrumbs.test.ts:
 8 pass  0 fail  8 expect() calls

@orbit/web test: Ran 498 tests across 80 files. Exited with code 0

A crumb links only when its accumulated path resolves to a real route, so unrouted parents (/team, /issue) and the current page stay text and nothing links to a 404. Live dev-server screenshot skipped: next dev currently 500s on every route from an unrelated Turbopack + react-email/prettier module-externalization issue, present on main.

Breadcrumb segments rendered as plain text with an unused href field. Extract a pure breadcrumbsFor builder that accumulates ancestor paths and marks each crumb navigable only when it resolves to a real route, then render those crumbs as Link. The current page and unrouted parents stay as text so no crumb links to a 404.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a302482-9ea0-4a1e-a6fa-4f0fd9478616

📥 Commits

Reviewing files that changed from the base of the PR and between 6e7001f and c84ad6b.

📒 Files selected for processing (4)
  • apps/web/src/components/layout/top-bar.tsx
  • apps/web/src/components/layout/workspace-shell.tsx
  • apps/web/src/lib/breadcrumbs.test.ts
  • apps/web/src/lib/breadcrumbs.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/breadcrumb-navigation

Comment @coderabbitai help to get the list of available commands.

@pulkitxm
pulkitxm merged commit ceb0f05 into main Jul 24, 2026
5 checks passed
@pulkitxm
pulkitxm deleted the fix/breadcrumb-navigation branch July 24, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant