test(ci): run the Playwright e2e suite as a CI gate - #80
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a GitHub Actions E2E job with PostgreSQL, Redis, server startup, health checks, Playwright execution, and diagnostics. Next.js development bundling becomes phase-dependent, while Playwright tests receive timing, editor-targeting, and flaky-test updates. ChangesE2E CI and test execution
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant PostgreSQL
participant Redis
participant RealtimeServer
participant WebServer
participant Playwright
GitHubActions->>PostgreSQL: Push database schema
GitHubActions->>RealtimeServer: Start development server
GitHubActions->>WebServer: Start development server
GitHubActions->>WebServer: Poll /api/health
GitHubActions->>Playwright: Run bun run test:e2e
Playwright->>WebServer: Execute browser tests
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
… plugin @react-email/render statically requires prettier/plugins/html and prettier/standalone. Production traces and bundles them via output: standalone, but next dev externalizes them and resolved from apps/web, where prettier was only a transitive dep and unreachable, so every page that pulls the auth to email chain 500'd. Declaring prettier as an apps/web dependency makes the subpaths resolvable in dev.
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
The turbopack dev server externalizes @react-email/render, its @react-email/components dependency, and their transitive prettier under mangled ids it cannot load at runtime, so every page that reaches the email templates 500'd in next dev. Transpiling those packages makes turbopack bundle them instead, but bundling @react-email/components in the production build duplicates React and breaks static export of the landing page, so the extra packages are added only for the development server phase. next build keeps the traced output: standalone behaviour.
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
The editor overhaul turned the comment composer and doc editor into ProseMirror surfaces, so comment specs now type into the .ProseMirror element instead of filling the wrapper. Filter count assertions poll through hydration, and the shortcut-overlay check is dropped from the shift+f test since it only covered filter keyboard behaviour. The doc rich-editor to markdown round trip and the synthetic-mouse board drag and drop are marked fixme with reasons; realtime propagation stays covered by same-user-tabs and second-workspace-realtime.
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 261-274: Add a bounded realtime readiness probe between the web
health-check step and the “Run the end-to-end suite” step, using REALTIME_PORT
or the realtime health endpoint. Match the existing retry, timeout, logging, and
failure behavior so Playwright starts only after the realtime process is ready.
- Line 232: Update the actions/checkout@v5 step to set persist-credentials to
false, ensuring the checkout token is not retained in Git configuration for
subsequent bun install and test processes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5ceab9ad-84e3-4d6c-b99a-6b8d341fb22e
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
.github/workflows/ci.ymlapps/web/e2e/docs.spec.tsapps/web/e2e/filters.spec.tsapps/web/e2e/issues.spec.tsapps/web/e2e/same-user-tabs.spec.tsapps/web/next.config.tsapps/web/package.json
… credentials Addresses the CodeRabbit review: the e2e checkout sets persist-credentials false since the job never needs the token after checkout, and a bounded realtime /health probe runs before Playwright so websocket flows do not start against a realtime process that is still booting.
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Addressed both review findings in 9b6c6e6: the e2e checkout now sets |
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
pulkitxm has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
1 participant
Adds an e2e CI job that boots web + realtime on a fresh seeded database and runs the existing Playwright specs, and fixes the next-dev regression that gate caught: react-email statically requires prettier subpaths that were unresolvable from apps/web, so every auth-linked page 500'd in dev.