Fix table sorting in chrome.#1637
Merged
Novik merged 1 commit intoNovik:masterfrom Jan 12, 2018
Merged
Conversation
4 tasks
xirvik
added a commit
that referenced
this pull request
Apr 22, 2026
Chrome fires mousemove events on mousedown/mouseup even when the mouse has not moved (movementX === 0, movementY === 0). This caused the DnD handler to set isMoving=true on every click, triggering column drag instead of sort. Guard against zero-movement events in onRun callback. Previously fixed in PR #1637 but lost during DnD class refactor. Fixes #3001
xirvik
added a commit
that referenced
this pull request
Apr 22, 2026
Chrome fires mousemove events on mousedown/mouseup even when the mouse hasn't physically moved (movementX === 0, movementY === 0). This caused the DnD handler's onRun callback to set isMoving = true on every click, triggering the column drag path instead of the sort path. Add a guard to ignore zero-movement events before setting isMoving. Previously fixed in PR #1637 but lost during the DnD class refactor. Fixes #3001 Note: Couldn't repro, so maybe Chrome already fixed the issue on their end, but the change is harmless so why not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome has a different behavior then other browsers were the click event also triggers the mouseMove event.
This is just a little work around so that the event is not fired and you can sort columns consistently.
Issue:
#1195