throttle: apply throttle server-side so raw commands need no whitelisting#3079
Merged
Merged
Conversation
…ting Since raw XMLRPC from the client is now forwarded as untrusted (subject to rtorrent's command whitelist), the throttle plugin's per-torrent apply broke: it built d.stop / d.set_throttle_name / d.start commands in the browser and sent them as raw RPC. Making that work again would mean whitelisting stop/start/throttle-name for all untrusted callers. Instead, route the action through the plugin's own action.php: the client posts only the throttle value and a hash list, and the new rThrottle::apply() validates each hash (40 hex chars) and issues the commands over the trusted connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since raw XMLRPC from the client is now forwarded as untrusted (subject to rtorrent's command whitelist), the throttle plugin's per-torrent apply broke: it built d.stop / d.set_throttle_name / d.start commands in the browser and sent them as raw RPC. Making that work again would mean whitelisting stop/start/throttle-name for all untrusted callers.
Instead, route the action through the plugin's own action.php: the client posts only the throttle value and a hash list, and the new rThrottle::apply() validates each hash (40 hex chars) and issues the commands over the trusted connection