fix(sshx): mount the 9p share on a disk VM - #31
Conversation
setup-alpine writes a fresh guest fstab with no 9p lines. The apkovl overlay's fstab only covers the live installer environment, so an installed disk VM never mounts /mnt/host or /mnt/work. Factor the 9p mount spec (tag, dir, options) into internal/apkovl so the overlay and the new step share one definition. Provision now runs an idempotent mount step over ssh, before the recipe loop, for a disk-mode VM with Share set. A failed mount only logs and continues, matching the overlay's own nofail option.
|
Warning Review limit reached
Next review available in: 58 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part B of the auto-provision design (spec: 2026-08-10-auto-provision).
/mnt/hostis empty on every disk VM. The 9p fstab line lives in the apkovl overlay, which configures the live installer only; setup-alpine writes a fresh disk system that never inherits it.Provisionnow runs a share-mount step over ssh right afterWaitsucceeds, before the recipes. It fires only for a disk VM withShareset — a live VM already mounts through the overlay, and a cloud VM uses cloud-init.qemu.Argsattaches theworkvirtfs to every VM, so a disk VM gets bothhostandwork.The step is idempotent and best-effort: for each tag it appends the fstab line only when the mountpoint is absent (anchored grep so "work" can't match "network"), and mounts only when
mountpoint -qsays it isn't. A mount failure is logged and the recipes still run, matching the overlay's ownnofail.The 9p mount spec (tag, dir, options) is now one
apkovl.Mount9pvalue that bothapkovl.Buildand this step consume, so the overlay and the installed system cannot drift.apkovl.Build's fstab output is byte-identical (existing apkovl tests confirm).Tests: the fstab-append fragment runs against a real temp file to prove idempotency; the step is skipped for live, cloud, and share-less disk VMs.
just checkandjust testpass.