Skip to content

fix(sshx): mount the 9p share on a disk VM - #31

Merged
NovusEdge merged 1 commit into
mainfrom
sshx-share-mount
Aug 9, 2026
Merged

fix(sshx): mount the 9p share on a disk VM#31
NovusEdge merged 1 commit into
mainfrom
sshx-share-mount

Conversation

@NovusEdge

Copy link
Copy Markdown
Owner

Part B of the auto-provision design (spec: 2026-08-10-auto-provision).

/mnt/host is empty on every disk VM. The 9p fstab line lives in the apkovl overlay, which configures the live installer only; setup-alpine writes a fresh disk system that never inherits it.

Provision now runs a share-mount step over ssh right after Wait succeeds, before the recipes. It fires only for a disk VM with Share set — a live VM already mounts through the overlay, and a cloud VM uses cloud-init. qemu.Args attaches the work virtfs to every VM, so a disk VM gets both host and work.

The step is idempotent and best-effort: for each tag it appends the fstab line only when the mountpoint is absent (anchored grep so "work" can't match "network"), and mounts only when mountpoint -q says it isn't. A mount failure is logged and the recipes still run, matching the overlay's own nofail.

The 9p mount spec (tag, dir, options) is now one apkovl.Mount9p value that both apkovl.Build and this step consume, so the overlay and the installed system cannot drift. apkovl.Build's fstab output is byte-identical (existing apkovl tests confirm).

Tests: the fstab-append fragment runs against a real temp file to prove idempotency; the step is skipped for live, cloud, and share-less disk VMs. just check and just test pass.

setup-alpine writes a fresh guest fstab with no 9p lines. The apkovl
overlay's fstab only covers the live installer environment, so an
installed disk VM never mounts /mnt/host or /mnt/work.

Factor the 9p mount spec (tag, dir, options) into internal/apkovl so
the overlay and the new step share one definition. Provision now runs
an idempotent mount step over ssh, before the recipe loop, for a
disk-mode VM with Share set. A failed mount only logs and continues,
matching the overlay's own nofail option.
@NovusEdge NovusEdge added the bug Something isn't working label Aug 9, 2026
@NovusEdge NovusEdge self-assigned this Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@NovusEdge, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 32d023f2-61db-4dc9-bb52-ab03befa942c

📥 Commits

Reviewing files that changed from the base of the PR and between 69a4558 and a729f0a.

📒 Files selected for processing (5)
  • internal/apkovl/apkovl.go
  • internal/apkovl/mount9p.go
  • internal/sshx/sharemount.go
  • internal/sshx/sharemount_test.go
  • internal/sshx/sshx.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NovusEdge
NovusEdge merged commit d5ad100 into main Aug 9, 2026
8 checks passed
@NovusEdge
NovusEdge deleted the sshx-share-mount branch August 9, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant