fix(tui): follow the terminal background - #98
Merged
Conversation
The main TUI drew the dark palette on every terminal. Against #F7F7F7 the six colours measured between 2.04:1 and 4.01:1, all below WCAG AA. #95 added theme.For for the installer and left this UI on the fixed set. Init now requests the background colour and Update applies the matching palette. A terminal that never answers keeps the dark set. The styles stay package-level values: about 150 call sites read them by name, and one program draws with them at a time. Signed-off-by: NovusEdge <novusedge0@gmail.com>
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main TUI drew the dark palette on every terminal. Against
#F7F7F7the six colours measured between 2.04:1 and 4.01:1, all below WCAG AA. #95 addedtheme.Forand switched the installer; this switches the other consumer.Initnow batchestea.RequestBackgroundColoralongsideloadVMs, andUpdatecallsapplyPalette(msg.IsDark())when the answer arrives. A terminal that never answers keeps the dark set, which is what the unsuffixed constants ininternal/themeare.The styles stay package-level values. About 150 call sites read them by name, one program draws with them at a time, and the package has no parallel tests.
applyPaletterebuilds all of them, including the pane border.Tests
TestApplyPaletteFollowsTheBackgroundchecks the colours, the derived styles and the pane border in both directions.TestBackgroundColorMsgSwitchesThePalettedrives the realUpdatepath; removing theapplyPalettecall makes it fail withaccent at {201 138 91 255}, want {122 62 18 255}.go build,go vet,go test ./...andgofmt -l .are clean.