nuget pack -symbols: Missing source file error when the package contains XAML

[tom-englert]

A symbol package crated with "nuget pack -symbols" can't be uploaded to symbolsource.org if the package contains WPF/XAML controls. When analyzing or uploading the package it complains about missing files.
When looking at the content of the package, only the MapTile.xaml.cs file is in the package, but the analyzer insists that MapTile.xaml and MapTile.g.cs should be included, too.
The source of the project where this happens can be downloaded at https://tomstoolbox.codeplex.com/SourceControl/latest

[yishaigalatzer]

Yes! We have the same problem with out symbol packages

[tom-englert]

Files to be added should be determined by looking at the PDB - not by trial and error!
(This would e.g. also fix other issues, like #529)

If NuGet claims to support SymbolSorce, it should do it right, or otherwise drop the entire feature.

There is a plugin for the PackageManger that shows these errors already at the client, (https://github.com/SymbolSource/SymbolSource.Community/tree/master/Sources/SymbolSource.Integration.NuGet.PackageExplorer), so you could easily adapt the code from there to provide a symbol package that is bullet proof.

[yishaigalatzer]

We would take a pr if you are interested. Currently this is low on our priority list.

[tom-englert]

https://nuget.codeplex.com/SourceControl/network/forks/tomenglert/private/contribution/8243

[yishaigalatzer]

Thank you!

I'm not sure if we can take dependency on this 3rd party package or not. We need to check legally if it is ok or not. Is the official package not sufficient?

Also please refrain from todo in the code and add tests.

The good news (I assume) is that you are unblocked, right?

[tom-englert]

I just wanted to use the same package as SymbolSource does (they are open source too, so the license should be fine) so I can reuse some of their code and be sure the result is identical. I will try the official CCI package and replace it if it works.

Todos: I'll remove the one about the code smell and create a bug instead, since I'm not sure why the code is there and if it is important.
I can't handle localization by my own, how is the correct workflow for this one?

I will check if I can add some useful tests.