Fix assignee-picker 500, add user profile edit, fix flaky gate creation - #18
Merged
NubeDev merged 1 commit intoJul 16, 2026
Merged
Conversation
- #15: list_users_for_org_impl omitted `role` from its SELECT, which crashed the shared row_to_user mapper and 500'd GET /users?org_id=, leaving the issue/project assignee picker with zero options. Add the missing column plus a regression test. - #14: add PUT /admin/users/{id} to edit name/email (store method, pg impl, audit verb, admin-gated route, OpenAPI registration, frontend client + schema + an Edit dialog on the admin users page). - #17: batch gate-view (G1-G8) creation fired 8 concurrent fire-and-forget mutations and closed the dialog before any resolved, dropping ~half the tabs. Creation is now sequential, awaited, retried on failure, and surfaces errors instead of silently continuing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
NubeDev
deleted the
fix/issues-14-15-17-user-crud-assignee-picker-gate-views
branch
July 16, 2026 02:59
NubeDev
added a commit
that referenced
this pull request
Jul 16, 2026
Both sides independently fixed two bugs. Resolution: - orgs.rs (missing `role` in list_users_for_org_impl SELECT): identical on both sides, resolved itself. - G1-G8 gate race (#17): both sides fixed it differently. Kept the reconciling `onSubmitBatch` / `useCreateProjectViewBatch` path (re-lists and re-POSTs until every view exists) over #18's sequential-awaited loop. Batch doesn't route through `onCreateView`, so it has no per-view redirect to suppress. - Kept #18's `createWithRetry`, `creating` in-flight guard, and error toasts on the single/custom paths — unrelated to the batch design and not covered by our version. All non-overlapping #18 work (PUT /admin/users/{id}, users-page edit dialog, openapi snapshot, regression tests) taken as-is. Verified: cargo check + pnpm typecheck both clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cant assign a user to an issue/project even though there is user you cant select it #15: list_users_for_org_impl omitted
rolefrom its SELECT, which crashed the shared row_to_user mapper and 500'd GET /users?org_id=, leaving the issue/project assignee picker with zero options. Add the missing column plus a regression test.no way to CRUD users #14: add PUT /admin/users/{id} to edit name/email (store method, pg impl, audit verb, admin-gated route, OpenAPI registration, frontend client + schema + an Edit dialog on the admin users page).
move create views/gates to backend #17: batch gate-view (G1-G8) creation fired 8 concurrent fire-and-forget mutations and closed the dialog before any resolved, dropping ~half the tabs. Creation is now sequential, awaited, retried on failure, and surfaces errors instead of silently continuing.