Refactor and improve TrayApp implementation and dialog management#320
Merged
Conversation
… main popup's focusability.
- Detect Linux desktop environment and adjust positioning logic specifically for KDE. - Pre-calculate and update window position before showing dialog to ensure correct placement.
- Removed deprecated parameters and adjusted function signatures. - Simplified color filter and image rendering logic across overloads. - Cleaned up and consolidated visibility/positioning behaviors for better consistency. - Enhanced inline comments and removed redundant legacy documentation. - Improved platform-specific code and streamlined dialog state handling.
- Introduced `TrayAppImplLinux` and `TrayAppImplOriginal` for improved maintainability. - Consolidated positioning and visibility logic for macOS/Windows and Linux platforms. - Enhanced comments and added clarity to platform-specific behavior. - Improved dialog state management, reducing race conditions and ensuring consistent behavior across platforms.
The redundant invisible `DialogWindow` implementation was removed to clean up the code. This change does not affect functionality but improves maintainability and readability.
- Eliminated unused code for maintaining a cleaner and more maintainable codebase. - Updated the remaining `DialogWindow` logic for explicit dismissal requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request focuses on cleaning up and refactoring the
TrayAppimplementation to improve maintainability, enhance platform-specific logic, and refine dialog state management.Changes
DialogWindowdefinition and implementation to streamline the codebase.TrayAppImplLinuxandTrayAppImplOriginalclasses for better code separation and clarity.Impact