fix: honor '-' as stdin sentinel for message-text argument#17
Merged
Conversation
…gument resolveMessageText only treated '-' as "read from stdin" when passed via --file, so `message send <target> - <<EOF ... EOF` silently sent the literal string "-" instead of the heredoc body, contradicting the documented usage.
jonathanlam
marked this pull request as ready for review
July 23, 2026 22:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message send/message editonly treated-as "read from stdin" when passed via--file; a bare positional-(the form shown inSLACK_CLI_USAGE.md) was sent as the literal string-.resolveMessageTextnow reads stdin when the positional text argument is-, matching the documentedmessage send <target> - <<EOF ... EOFusage.cmd/message_test.go) covering this case, since none existed formessage.gopreviously.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.