chore: relocate REVIEW-*.md to docs/reviews/ - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repo root has accumulated 5 review-artefact files (
REVIEW-pr-57.md,REVIEW-pr-58.md,REVIEW-pr-62-round3.md,REVIEW-stack-42-47.md,REVIEW-stack-51-55.md). Puregit mvintodocs/reviews/— content unchanged.Deferred m3 from the round-3 review of the modernization triple (PR #62 series). Picked up now as a 5-min cleanup PR while #66 CI runs.
Why bare-filename references in code/comments are fine
Several headers + tests reference these by bare filename (e.g.
recipe.h:135mentionsREVIEW-pr-58.md). The relocation doesn't break their meaning — the documents still exist under the same names. Anyone searching for them via grep finds them indocs/reviews/. Not worth touching working code for a path-only rename.Test plan
git mvpreserves history (verified viagit log --follow)docs/or absolute-path prefix (grep -rn 'REVIEW-' --include='*.md' --include='*.h' --include='*.cpp'returns only bare-filename mentions, which still resolve)