Chore/bump dependabot 2025 12 13#40
Open
NurRobin wants to merge 16 commits into
Open
Conversation
github-actions
Bot
added
chore
dependencies
NurRobin
had a problem deploying
to
dev-server
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR introduces developer workflow improvements through automated code formatting, dependency upgrades, and GitHub Actions workflow updates. The changes focus on establishing consistent code style via Spotless with git pre-commit hooks, while updating key build dependencies and CI/CD action versions to their latest releases.
Key Changes
- Added Spotless Maven plugin with pre-commit git hook for automatic code formatting (Java, Markdown, YAML)
- Upgraded Maven dependencies: sqlite-jdbc (3.46.0.1 → 3.51.1.0), junit-jupiter (5.10.2 → 6.0.1), checkstyle (10.21.4 → 12.2.0), spotbugs (4.9.3.0 → 4.9.8.2), exec-maven-plugin (3.5.1 → 3.6.2)
- Updated all GitHub Actions workflows to use latest major versions (setup-java@v5, upload-artifact@v5, github-script@v8, codeql-action@v4, attest-build-provenance@v3)
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.githooks/pre-commit |
New pre-commit hook that runs Spotless formatting before commits |
scripts/install-githooks.sh |
Installation script to enable git hooks via core.hooksPath |
scripts/README.md |
Added documentation for git hooks setup process |
pom.xml |
Updated 5 dependencies, added Spotless plugin configuration with ratchetFrom strategy |
.github/workflows/snapshot.yml |
Updated to setup-java@v5 and upload-artifact@v5 |
.github/workflows/e2e-runtime-test.yml |
Updated to github-script@v8, removed trailing whitespace |
.github/workflows/dependency-report.yml |
Updated to setup-java@v5 and upload-artifact@v5 |
.github/workflows/coverage.yml |
Updated to setup-java@v5 and upload-artifact@v5 |
.github/workflows/codeql.yml |
Updated to codeql-action@v4 |
.github/workflows/build.yml |
Updated to setup-java@v5 and upload-artifact@v5, removed trailing whitespace |
.github/workflows/auto-release.yml |
Updated to setup-java@v5 and attest-build-provenance@v3, removed trailing whitespace |
Comment on lines
+12
to
+18
| if ! git show-ref --verify --quiet refs/remotes/origin/dev; then | ||
| echo "[pre-commit] refs/remotes/origin/dev not found; skipping Spotless ratchet formatting." >&2 | ||
| exit 0 | ||
| fi | ||
|
|
||
| echo "[pre-commit] Running Spotless (format + remove unused imports)…" >&2 | ||
| mvn -q -DskipTests spotless:apply |
There was a problem hiding this comment.
The pre-commit hook checks for refs/remotes/origin/dev but exits silently if it doesn't exist. This could cause formatting to be skipped in repositories where the dev branch hasn't been fetched yet, leading to inconsistent formatting across developers. Consider either requiring the branch to exist or using a fallback strategy (e.g., checking if HEAD is on main/dev and skipping only in those cases).
Suggested change
| if ! git show-ref --verify --quiet refs/remotes/origin/dev; then | |
| echo "[pre-commit] refs/remotes/origin/dev not found; skipping Spotless ratchet formatting." >&2 | |
| exit 0 | |
| fi | |
| echo "[pre-commit] Running Spotless (format + remove unused imports)…" >&2 | |
| mvn -q -DskipTests spotless:apply | |
| # Determine ratchet base: prefer dev, then main, else none | |
| if git show-ref --verify --quiet refs/remotes/origin/dev; then | |
| RATCHET_BASE="origin/dev" | |
| elif git show-ref --verify --quiet refs/remotes/origin/main; then | |
| RATCHET_BASE="origin/main" | |
| else | |
| RATCHET_BASE="" | |
| fi | |
| if [ -n "$RATCHET_BASE" ]; then | |
| echo "[pre-commit] Running Spotless (format + remove unused imports, ratchet: $RATCHET_BASE)…" >&2 | |
| mvn -q -Dspotless.ratchetFrom="$RATCHET_BASE" -DskipTests spotless:apply | |
| else | |
| echo "[pre-commit] No dev/main branch found; running Spotless on all files." >&2 | |
| mvn -q -DskipTests spotless:apply | |
| fi |
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NurRobin
had a problem deploying
to
dev-server
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project's build tooling and developer workflow. The most significant changes are the addition of automatic code formatting via Spotless (integrated with a new pre-commit git hook), upgrades to various Maven dependencies and plugins, and updates to GitHub Actions workflows to use the latest versions of key actions.
Developer workflow enhancements:
.githooks/pre-commit) that automatically runs Spotless to format code and remove unused imports before each commit, and provided a script (scripts/install-githooks.sh) to install the hooks. Documentation was updated to explain the setup process. [1] [2] [3]Build and code quality tooling:
spotless-maven-pluginintopom.xmlfor automated code formatting, including configuration for Java, Markdown, YAML, and.gitignorefiles.pom.xml, includingsqlite-jdbc,junit-jupiter,checkstyle,spotbugs-maven-plugin, andexec-maven-pluginto their latest versions for improved security and compatibility. [1] [2] [3] [4]CI/CD workflow updates:
actions/setup-java@v5,actions/upload-artifact@v5,actions/github-script@v8,actions/attest-build-provenance@v3, andgithub/codeql-action@v4. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]These changes streamline development by enforcing consistent code formatting, keeping dependencies up to date, and ensuring CI workflows use the latest features and security updates.