Draft: Add comprehensive tests - #53
Draft
DevilPedrow wants to merge 43 commits into
Draft
Conversation
…or beatmap control points and metadata handling
…resentation and comparison
…with dataclass fields
… dataclass fields
…sound type handling
…e Section to use StrEnum for improved type handling
…quality checks and using field defaults
…, and simplify General dataclass initialization
…implify dataclass initialization by removing equality checks
…data dataclass initialization by removing equality checks
…ng equality checks and updating field definitions, and add apply method for HitSampleInfo handling
…m_value method for improved documentation
…ng equality checks
… removing equality checks
🤖 ParseCore Bot — PR ReviewHi @DevilPedrow! I checked this pull request automatically. Here is my verdict: ❌ Not ready yetSome checks did not pass. Please fix the points marked with ❌ below and I will re-check automatically on your next push or edit.
What to fix
🤖 I am not a human I re-run on every push and edit. Configure me in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will include all the necessary tests for Parsecore. It will be essential to verify that the expected results are correct in the event of changes to the Beatmap, Mods, or Performance.
Resolving the issue #47
Type of Change
Changes
Testing
Breaking Changes
N/A
Parity
N/A
Checklist
#comments discouraged — see CONTRIBUTING.md)parsecore/Performance/change (parity suite: 0 differences)pre-commit run --all-files)