Skip to content

Resolve superseded calendar approvals - #3

Open
O1af wants to merge 1 commit into
mainfrom
olaf/gca-5-fix-approval-tool-lifecycle-in-chat
Open

Resolve superseded calendar approvals#3
O1af wants to merge 1 commit into
mainfrom
olaf/gca-5-fix-approval-tool-lifecycle-in-chat

Conversation

@O1af

@O1af O1af commented May 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Deny pending Google Calendar approval requests when the user sends a new message instead of approving or denying.
  • Reuse that lifecycle path for prompt submissions and suggestion clicks so stale approval cards disappear before the next turn.
  • Add regression coverage for follow-up messages while an approval request is pending.

Root Cause

Prompt submissions and suggestion clicks called sendMessage directly, while only the approval buttons called addToolApprovalResponse. That left approval-requested tool parts in chat state when the user moved on with a new question.

Validation

  • pnpm run test
  • pnpm run lint
  • pnpm run build
  • pnpm run format:check attempted, but blocked by the existing formatter config trying to load vite.config.ts as an unsupported config file.

Linear: GCA-5

@O1af
O1af marked this pull request as ready for review May 7, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant