Skip to content

[10.0]Oauth better decoding of Oauth provider response#692

Closed
flotho wants to merge 1 commit into
OCA:10.0from
MindAndGo:FIX-10.0-Oauth-apereo-provider
Closed

[10.0]Oauth better decoding of Oauth provider response#692
flotho wants to merge 1 commit into
OCA:10.0from
MindAndGo:FIX-10.0-Oauth-apereo-provider

Conversation

@flotho
Copy link
Copy Markdown
Member

@flotho flotho commented Jan 15, 2018

Description of the issue/feature this PR addresses:

Current behavior before PR:

  • Response kw['state'] is presented in a non decoded json :
    unicode: %7B%22p%22%3A 4%2C %22r%22%3A %22http%253A%252F%252Flocalhost%253A8069%252Fweb%22%2C %22d%22%3A %22mag_prod10_2018_01_12%22%7D

Desired behavior after PR is merged:

  • Interpret the kw['state'] correctly

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@flotho
Copy link
Copy Markdown
Member Author

flotho commented Jan 15, 2018

Hi @pedrobaeza ,
Any comment or review on this would be appreciated.
Actually the travis failure seems weird to me and mostly not related to my PR.
regards

@pedrobaeza
Copy link
Copy Markdown
Member

You need to make the same PR to Odoo first and link it here.

@flotho
Copy link
Copy Markdown
Member Author

flotho commented Jan 15, 2018

Hi @pedrobaeza ,

Do I have to restart from a brand new fork of Odoo or wil the OCB be able to be merge into Odoo ?

@pedrobaeza
Copy link
Copy Markdown
Member

You need a new one forked from odoo/odoo and cherry-pick this commit.

@flotho
Copy link
Copy Markdown
Member Author

flotho commented Jan 20, 2018

Ok, finally I think that it's mostly an apereo issue and declared a bug there : https://groups.google.com/a/apereo.org/forum/?utm_medium=email&utm_source=footer#!topic/cas-user/Lo441ONXa4Y
So I'm gonna patch this via a custom module until apereo told me if it's a bug from their part.

regards

@flotho flotho closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants