Skip to content

[ADD] main coverage file#2964

Merged
pedrobaeza merged 7 commits intoOCA:15.0from
legalsylvain:15.0-ADD-coverage-file
Nov 15, 2021
Merged

[ADD] main coverage file#2964
pedrobaeza merged 7 commits intoOCA:15.0from
legalsylvain:15.0-ADD-coverage-file

Conversation

@legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Nov 11, 2021

FIX CI

  • exclude noupdate_changes.xml
  • doc : point to correct 130-140 file

scripts

  • fill apriori.py file

Doc

@pedrobaeza
Copy link
Member

The sorting is important though

@StefanRijnhart
Copy link
Member

Can we prevent upgrade_analysis and other non-core modules from showing up here?

@MiquelRForgeFlow
Copy link
Contributor

Can we prevent upgrade_analysis and other non-core modules from showing up here?

In the excluded modules, you have to put all non core modules if you are running it with other OCA repos.

@MiquelRForgeFlow MiquelRForgeFlow added this to the 15.0 milestone Nov 11, 2021
@StefanRijnhart
Copy link
Member

Can we prevent upgrade_analysis and other non-core modules from showing up here?

In the excluded modules, you have to put all non core modules if you are running it with other OCA repos.

Not really, because records are generated for all installed modules, including upgrade_analysis which is required to be installed to generate the analysis.
I was thinking along the lines to filter out any non-odoo module in this report because, well, that's the scope of the report.

@legalsylvain
Copy link
Contributor Author

I propose to talk of the topic here. OCA/server-tools#2206
as this PR is just a result.

@legalsylvain legalsylvain force-pushed the 15.0-ADD-coverage-file branch from 32ecfb6 to b70aae1 Compare November 12, 2021 12:19
@legalsylvain
Copy link
Contributor Author

legalsylvain commented Nov 12, 2021

regarding the del modules, a very quick first analysis provides the following :

  • account_edi_extended. merged into account_edi
  • adyen_platforms. Not found.
  • crm_iap_lead renamed into crm_iap_mine
  • crm_iap_lead_enrich renamed into crm_iap_enrich
  • l10n_be_invoice_bba merged into l10n_be.
  • l10n_ch_qr_iban merged into l10n_ch
  • l10n_eu_service renamed into l10n_eu_oss
  • l10n_se_ocr merged into l10n_se
  • mail_client_extension renamed into mail_plugin
  • odoo_referral : Not found.
  • payment_fix_register_token : merged into payment
  • payment_ingenico renamed into payment_ogone
  • odoo_adyen_account_id : Not found.
  • _action_launch_stock_rule : merged into sale_stock
  • sale_timesheet_edit : merged into sale_timesheet
  • sale_timesheet_purchase : Not found.
  • website_event_track_exhibitor merged into website_event_exhibitor
  • website_form merged into website
  • website_mail_channel : Not found.
  • website_sale_management merged into website_sale

@OCA/openupgrade-maintainers : could you take a look on that proposal ?
If you confirm, I could update the apriori file to have a more precise analysis files.

kind regards.

@legalsylvain legalsylvain marked this pull request as ready for review November 12, 2021 23:45
@pedrobaeza
Copy link
Member

Yes, I confirm, except _action_launch_stock_rule that I don't locate

@legalsylvain
Copy link
Contributor Author

legalsylvain commented Nov 13, 2021

Yes, I confirm, except _action_launch_stock_rule that I don't locate

My bad. Bad copy paste i was talking about procurement_jit, merged into sale_stock.

_action_launch_stock_rule is a function i was looking for.

Thanks for the review.

@legalsylvain legalsylvain force-pushed the 15.0-ADD-coverage-file branch from 0602bfa to 3671967 Compare November 15, 2021 00:10
…uld be filled by openupgrader, and a column that is automatically filled when importing apriori and making analysis
@legalsylvain legalsylvain force-pushed the 15.0-ADD-coverage-file branch from f6db860 to e633253 Compare November 15, 2021 12:50
@legalsylvain
Copy link
Contributor Author

For me, this is ready to merge.

CC : @StefanRijnhart, @pedrobaeza

@pedrobaeza pedrobaeza merged commit 66b7495 into OCA:15.0 Nov 15, 2021
@legalsylvain
Copy link
Contributor Author

thanks for your reviews !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants