15.0 mig openupgrade framework by legalsylvain · Pull Request #2967 · OCA/OpenUpgrade

legalsylvain · 2021-11-15T10:53:04Z

Hi all.

I just executed meld on odoo subfolder to check the differences, to guess if the openupgrade_framework was requiring changes.
At first sight : very fiew changes.

some changes related to base framework (for information)

[IMP] core: introduce api.ondelete decorator (odoo/odoo@1c8a958)
[IMP] core: allow set [value] in selection ondelete. (odoo/odoo@cc768f3)
[IMP] base: remove get_object helper (odoo/odoo@fd67339)

Some changes related to OpenUpgrade framework

lot of changes in _check_xml. Specially odoo/odoo@46f1912. Nothing to do in my opinion
lot of changes in _post_process_view. Here odoo/odoo@331b547. Nothing to do in my opinion
handle_view_error has been splitted in two functions here odoo/odoo@9ae8c1a. TODO

openupgrade_scripts/scripts/base/15.0.1.3/pre-migration.py

oerp-odoo · 2022-01-31T08:49:10Z

Whats the status of this PR? Is it possible to get it merged soon?

sutidor · 2022-04-06T08:23:13Z

Nice. Looking forward to see this done.

legalsylvain · 2022-04-06T21:02:52Z

Hi. This PR is WIP.
No time immediately. Help welcome.

regards.

royle-vietnam · 2022-04-27T01:20:45Z

openupgrade_scripts/scripts/base/15.0.1.3/pre-migration.py

+            "recommended to run the Odoo with --load=openupgrade_framework "
+            "when migrating your database."
+        )
+        openupgrade.rename_xmlids(cr, [("mail.icp_mail_catchall_alias", "base.icp_mail_catchall_alias")])


Line too long and correct indentation

Suggested change

openupgrade.rename_xmlids(cr, [("mail.icp_mail_catchall_alias", "base.icp_mail_catchall_alias")])

openupgrade.rename_xmlids(

cr,

[

("mail.icp_mail_catchall_alias", "base.icp_mail_catchall_alias"),

("mail.icp_mail_bounce_alias", "base.icp_mail_bounce_alias"),

],

)

royle-vietnam · 2022-04-27T01:32:27Z

openupgrade_framework/odoo_patch/odoo/addons/base/models/ir_ui_view.py

+def _postprocess_view(self, node, model, validate=True, editable=True):
+    """Don't validate views, _raise_view_error is mutted"""
+    return View._postprocess_view._original_method(
+        self, node, model, validate=False, editable=editable
+    )


@legalsylvain correct number of args

Suggested change

def _postprocess_view(self, node, model, validate=True, editable=True):

"""Don't validate views, _raise_view_error is mutted"""

return View._postprocess_view._original_method(

self, node, model, validate=False, editable=editable

)

def _postprocess_view(self, node, model, editable=True):

"""Don't validate views, _raise_view_error is mutted"""

return View._postprocess_view._original_method(

self, node, model, editable=editable

)

royle-vietnam · 2022-04-27T01:37:38Z

@legalsylvain Looking forward to see this done. Could you make a todo list to follow / help?

legalsylvain · 2022-04-30T18:08:54Z

@royleviindoo.
Thanks for the ping.

I haven't worked on this RP for a while, so I'm not sure!
I'll plan to work on it again, the week of May 9, and let you know what it is.

Have a good weekend.

jcdrubay · 2022-05-11T12:20:24Z

@royleviindoo FYI, I am currently working on this fork https://github.com/jcdrubay/OpenUpgrade/tree/15.0-add-xml-ids-moved-from-mail-to-base

royle-vietnam · 2022-05-12T07:25:23Z

@royleviindoo FYI, I am currently working on this fork https://github.com/jcdrubay/OpenUpgrade/tree/15.0-add-xml-ids-moved-from-mail-to-base

Hi @jcdrubay , I looked at your repository, but didn't see any difference
FYI, Our company is currently working on repo https://github.com/Viindoo/OpenUpgrade/blob/15.0/docsource/modules140-150.rst

legalsylvain · 2022-05-12T07:31:53Z

@royleviindoo : you can review the diff hère :

legalsylvain#4

legalsylvain · 2022-05-13T14:08:26Z

Hi @jcdrubay. CI is now green. Thanks !

just tested a migration from 14 to 15 with that up-to-date branch (account + web_responsive installed).

migration passed
V15 is available

Some remaining points :

I have a warning

2022-05-13 13:33:52,958 1 WARNING test__openupgrade__14__15_a py.warnings: /usr/lib/python3.9/contextlib.py:117: DeprecationWarning: Since Odoo 15.0, Environment.manage() is useless.

  File "/odoo_env/src/openupgrade/openupgrade_framework/odoo_patch/odoo/modules/migration.py", line 17, in migrate_module
    MigrationManager.migrate_module._original_method(self, pkg, stage)
  File "/odoo_env/src/odoo/odoo/modules/migration.py", line 180, in migrate_module
    migrate(self.cr, installed_version)
  File "/usr/local/lib/python3.9/dist-packages/openupgradelib/openupgrade.py", line 1992, in wrapped_function
    contextmanagers.enter_context(api.Environment.manage())

Something should be fixed in openupgradelib project.

I have a lot of logs, related to renaming :
2022-05-13 13:33:44,614 1 INFO test__openupgrade__14__15_a OpenUpgrade: XMLID l10n_ec.state_ec_1 not found when renaming to base.state_ec_01

Fixed here : aebb0d2

Did you planned to finish base migration ? it seems there are some points present in the analysis files that are not handled ? (just a question)

jcdrubay · 2022-05-13T14:33:57Z

I would be happy to continue the work on base module.
It would help me a lot if you could pinpoint some of the remaining tasks to do as I did not realize something was missing.

If we don't include it, /jsonrpc route doesn't work.

If you have a module in previous versions that adds data on a model, and such model is not loaded in the registry in current version because the module is absent in it, you can't uninstall such module, getting this error: File "odoo/odoo/addons/base/models/ir_model.py", line 1945, in _module_data_uninstall delete(self.env[model].browse(item[1] for item in items)) File "odoo/odoo/api.py", line 463, in __getitem__ return self.registry[model_name]._browse(self, (), ()) File "odoo/odoo/modules/registry.py", line 177, in __getitem__ return self.models[model_name] KeyError: 'model' With this patch, data cleanup of such model is skipped and there's no crash.

…ore ; add links to the new OpenUpgrade website

If corresponding field is None, we need to avoid the "AttributeError: 'NoneType' object has no attribute error.

…view_error

Co-authored-by: Jean-Charles Drubay <jcdrubay@users.noreply.github.com>

…rg validate as it is not anymore in odoo 15

…o the module base

…e useless after the input argument validate has been removed

MiquelRForgeFlow

LGTM

legalsylvain mentioned this pull request Nov 15, 2021

Initialize OpenUpgrade 15 #2915

Closed

9 tasks

legalsylvain force-pushed the 15.0-mig-openupgrade_framework branch from 343a106 to 8f33a33 Compare November 15, 2021 22:08

jcdrubay reviewed Jan 11, 2022

View reviewed changes

openupgrade_scripts/scripts/base/15.0.1.3/pre-migration.py Show resolved Hide resolved

legalsylvain added this to the 15.0 milestone Mar 3, 2022

royle-vietnam reviewed Apr 27, 2022

View reviewed changes

legalsylvain force-pushed the 15.0-mig-openupgrade_framework branch from aebb0d2 to 7d5849b Compare May 13, 2022 14:09

legalsylvain marked this pull request as ready for review May 13, 2022 14:11

legalsylvain and others added 12 commits May 17, 2022 10:13

[INIT] Full refactor of the OpenUpgrade project

2bc7b75

[DEL] openupgrade_records -> server-tools/14.0

4a8134b

[RFR] OpenUpgrade framework patches

9780f33

[UPD] README.rst

4d18ad0

[ADD] icon.png

81f00db

[FIX] _logger.warn -> _logger.warning

1d4e542

[FIX] doc: base must be included in --load parameter

76f56d1

If we don't include it, /jsonrpc route doesn't work.

[UPD] README.rst

8345eb8

[FIX] openupgrade_framework: _drop_column was in wrong class

51e7050

[DOC] add banner file, to make this module more visible on the app st…

44ab6a7

…ore ; add links to the new OpenUpgrade website

[UPD] README.rst

2fe3e61

StefanRijnhart and others added 20 commits May 17, 2022 10:13

[FIX] Don't break on missing model in selection _process_ondelete

2c1e770

[REF] Add maintainers

81460ca

[UPD] README.rst

e69daf6

[IMP] openupgrade_framework: avoid AttributeError in view validation

88d4432

If corresponding field is None, we need to avoid the "AttributeError: 'NoneType' object has no attribute error.

[MIG][15.0] openupgrade_framework

2701545

[REF] adapt framework, due to renaming handle_view_error into _raise_…

1a68e21

…view_error

[WIP][15.0] base module

0292bda

fixup! [WIP][15.0] base module

97903e8

fixup! fixup! [WIP][15.0] base module

9a2f587

Update openupgrade_scripts/scripts/base/15.0.1.3/pre-migration.py

6d87a1f

Co-authored-by: Jean-Charles Drubay <jcdrubay@users.noreply.github.com>

Update method _postprocess_view of ir_ui_view by removing the input a…

68e5ec4

…rg validate as it is not anymore in odoo 15

[MIG] Rename the xml ids which have been moved from the module mail t…

742cad9

…o the module base

[MIG] remove the odoo_patch on function _postprocess_view which becam…

ac75055

…e useless after the input argument validate has been removed

pre-migration: Add call to rename/merge modules

9f9de9f

Add the move of xml_id for the the res.country.states from l10n_ec

a171226

[MIG] Upgrade version in .github/workflows/test.yml + code refactoring

ffee8a0

Adjustements for code style

06f68db

Uncomment line to drop old db

219f19d

[FIX] pre-commit update

1c6769c

[IMP] rename xml_ids only if installed in previous version

0b28097

MiquelRForgeFlow force-pushed the 15.0-mig-openupgrade_framework branch 3 times, most recently from bb02612 to e4c3934 Compare May 17, 2022 08:48

[FIX] base: finish migration

130d038

MiquelRForgeFlow force-pushed the 15.0-mig-openupgrade_framework branch from e4c3934 to 130d038 Compare May 17, 2022 08:50

MiquelRForgeFlow approved these changes May 17, 2022

View reviewed changes

pedrobaeza merged commit c5be4f4 into OCA:15.0 May 18, 2022

legalsylvain mentioned this pull request Jun 15, 2022

Migration to version 15.0 #3287

Open

Uh oh!

Conversation

legalsylvain commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

oerp-odoo commented Jan 31, 2022

Uh oh!

sutidor commented Apr 6, 2022

Uh oh!

legalsylvain commented Apr 6, 2022

Uh oh!

royle-vietnam Apr 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

royle-vietnam Apr 27, 2022

Choose a reason for hiding this comment

Uh oh!

royle-vietnam commented Apr 27, 2022

Uh oh!

legalsylvain commented Apr 30, 2022

Uh oh!

jcdrubay commented May 11, 2022

Uh oh!

royle-vietnam commented May 12, 2022

Uh oh!

legalsylvain commented May 12, 2022

Uh oh!

legalsylvain commented May 13, 2022

Uh oh!

jcdrubay commented May 13, 2022

Uh oh!

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

legalsylvain commented Nov 15, 2021 •

edited

Loading

royle-vietnam Apr 27, 2022 •

edited

Loading