Conversation
|
/ocabot migration stock |
gdgellatly
left a comment
There was a problem hiding this comment.
I just static review, but I am not very good at this, it is more for other reviewers to confirm if I am stupid than for dev to take action.
There was a problem hiding this comment.
Is there a chance we get a lot of these?
Maybe
| SET name = 'Unknown Pack' | |
| SET name = 'Unknown Pack ' || id::text |
I never use packages so maybe it is irrelevant, just a comment.
There was a problem hiding this comment.
This field is required from 15.0, but at 14.0 it was set default value via self.env['ir.sequence'].next_by_code('stock.quant.package') and didn't insert by SQL before. So I think we don't need set value for it during migration from 14.0 to 15.0.
There was a problem hiding this comment.
After reviewing, I think we still need to migrate here. Although stock.quant.package are usually created via transfers but it has some views and end user can edit it. It mean name of stock.quant.package can be blank.
There was a problem hiding this comment.
This field is required from 15.0, but at 14.0 it was set default value via self.env['ir.sequence'].next_by_code('stock.quant.package') and didn't insert by SQL before. So I think we don't need set value for it during migration from 14.0 to 15.0.
77949bd to
0c7b945
Compare
|
Superseded by #3510. |
This PR
Migration done