Skip to content

[MIG][15.0] gamification: migration script#3340

Merged
MiquelRForgeFlow merged 1 commit intoOCA:15.0from
sang250399:v15_mig_gamification_2
Jul 27, 2022
Merged

[MIG][15.0] gamification: migration script#3340
MiquelRForgeFlow merged 1 commit intoOCA:15.0from
sang250399:v15_mig_gamification_2

Conversation

@sang250399
Copy link

This PR

Migration done

@legalsylvain
Copy link
Contributor

/ocabot migration gamification

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 23, 2022
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @sang250399

A question regarding noupdate_changes.xml

You are updating mail.template. I think that you should also reset translation for email_template_badge_received, email_template_goal_reminder and mail_template_data_new_rank_reached. Don't you think ?

See similar work :

https://github.com/OCA/OpenUpgrade/pull/3319/files#diff-46a6904a929ab8ba20acae0852dad5d3722dbb6c8e468cc5fb7268acfc1fa177R7

thanks.

@sang250399
Copy link
Author

Thanks again @sang250399

A question regarding noupdate_changes.xml

You are updating mail.template. I think that you should also reset translation for email_template_badge_received, email_template_goal_reminder and mail_template_data_new_rank_reached. Don't you think ?

See similar work :

https://github.com/OCA/OpenUpgrade/pull/3319/files#diff-46a6904a929ab8ba20acae0852dad5d3722dbb6c8e468cc5fb7268acfc1fa177R7

thanks.

sorry, my mistake. that is necessary, thank you

@sang250399 sang250399 force-pushed the v15_mig_gamification_2 branch from 4e51082 to 7102c73 Compare June 23, 2022 09:41
@sang250399 sang250399 force-pushed the v15_mig_gamification_2 branch from 7102c73 to 9ee447e Compare June 23, 2022 09:42
@daonamutc1
Copy link

@legalsylvain May you review again?

@MiquelRForgeFlow MiquelRForgeFlow merged commit 55aa9c1 into OCA:15.0 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants