[MIG] sale_timesheet_edit: nothing to do#3438
Merged
pedrobaeza merged 1 commit intoOCA:15.0from Mar 6, 2023
Merged
Conversation
Contributor
|
/ocabot migration sale_timesheet_edit |
pedrobaeza
requested changes
Mar 4, 2023
docsource/modules140-150.rst
Outdated
| | |new| sale_timesheet_margin |Nothing to do |No analysis file. No DB layout changes. | | ||
| +-------------------------------------------------+----------------------+-------------------------------------------------+ | ||
| | |del| sale_timesheet_purchase | | | | ||
| | |del| sale_timesheet_purchase |Nothing to do | | |
Member
There was a problem hiding this comment.
This is not correct. It should be merged with something.
Contributor
Author
There was a problem hiding this comment.
Hi, sorry i have been out for a longtime and can't quite remember this, do you remember which module it should be merged with?
P/s: probably i will comeback for upgrade 15 -> 16 in june ✌️
Member
There was a problem hiding this comment.
No, sorry, but if you don't remember, just remove this change and let the module non handled. It's also a good practice to not handle several modules in the same PR.
Contributor
Author
There was a problem hiding this comment.
Thank you, i'll keep in mind
daiduongnguyen-odoo
force-pushed
the
v15_mig_sale_timesheet!
branch
from
5bfd812 to
42567c3
Compare
pedrobaeza
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Nothing to do