[16.0][OU-FIX] purchase_requisition: Proper order group creation (and global) + no delete#5312
Merged
pedrobaeza merged 1 commit intoOCA:16.0from Aug 15, 2025
Conversation
…l) + no delete The PO groups weren't created properly before, so the new query is doing the correct job, and doing it for all the requisitions, not only those of one type. The previous code was also deleting all the requisitions of a deleted type, but doing that, apart from being partial, it's counter-productive, requiring a lot of work with no benefit, so let's keep them.
Member
Author
|
Tested and working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PO groups weren't created properly before, so the new query is doing the correct job, and doing it for all the requisitions, not only those of one type.
The previous code was also deleting all the requisitions of a deleted type, but doing that, apart from being partial, it's counter-productive, requiring a lot of work with no benefit, so let's keep them.
@Tecnativa