[18.0][OU-FIX] hr_holidays: do not duplicate multi employee leaves #5396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@MiquelRForgeFlow would you mind having a look at that one ? |
MiquelRForgeFlow
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-employee leaves and allocations once validated already created duplicate leave / allocation for each employee.
Current script by rewriting multi-employee leave / allocation to final employees was creating duplicate leave / allocation causing all leave counters to be wrong.
The duplication is only done in case leave / allocation is in 'to approve' state, otherwise the multi-employee leave / allocation is deleted.