Skip to content

[12.0][IMP] - Brand field is only editable in draft state for invoice and sale object - #23

Merged
OCA-git-bot merged 1 commit into
OCA:12.0from
acsone:12.0-brand_readonly_for_some_state-sbj
Feb 18, 2020
Merged

[12.0][IMP] - Brand field is only editable in draft state for invoice and sale object#23
OCA-git-bot merged 1 commit into
OCA:12.0from
acsone:12.0-brand_readonly_for_some_state-sbj

Conversation

@sbejaoui

Copy link
Copy Markdown
Contributor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @osi-scampbell,
some modules you are maintaining are being modified, check this out!

@sbejaoui sbejaoui changed the title [12.0][IMP] - Brand field is editable in draft state for invoice and sale object [12.0][IMP] - Brand field is only editable in draft state for invoice and sale object Feb 13, 2020

@gva-acsone gva-acsone left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 Functional test

@dreispt

dreispt commented Feb 18, 2020

Copy link
Copy Markdown
Member

/ocabot merge major

OCA-git-bot added a commit that referenced this pull request Feb 18, 2020
Signed-off-by dreispt
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-23-by-dreispt-bump-major, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
OCA-git-bot merged commit 292e9f2 into OCA:12.0 Feb 18, 2020
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b132cee. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants