Skip to content

[19.0][MIG] sale_commission_pricelist_oca: Migration to 19.0 - #677

Merged
OCA-git-bot merged 37 commits into
OCA:19.0from
ForgeFlow:19.0-mig-sale_commission_pricelist_oca
May 19, 2026
Merged

[19.0][MIG] sale_commission_pricelist_oca: Migration to 19.0#677
OCA-git-bot merged 37 commits into
OCA:19.0from
ForgeFlow:19.0-mig-sale_commission_pricelist_oca

Conversation

@AndreuOForgeFlow

Copy link
Copy Markdown

Migration to 19.0

@ForgeFlow

Added this IMP commit: c22eca7 to set the pricelist commission_id as fallback when pricelist item has none

carlosdauden and others added 30 commits May 19, 2026 10:42
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/zh_CN/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt_BR/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt_BR/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-13.0/commission-13.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_pricelist/es_AR/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/es/
@OCA-git-bot OCA-git-bot added mod:sale_commission_pricelist_oca Module sale_commission_pricelist_oca series:19.0 labels May 19, 2026

@JordiMForgeFlow JordiMForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, could you add a test for the new pricelist commission configuration?

…mission

The commission_id field exists on product.pricelist.item, requiring it
to be set on every rule. Add commission_id on product.pricelist so that
when an item has none, the rule falls back to the pricelist's value.
This makes it practical to configure a single commission per tier
without editing every rule.
@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 19.0-mig-sale_commission_pricelist_oca branch from c22eca7 to 1b55bc3 Compare May 19, 2026 10:51
@AndreuOForgeFlow

Copy link
Copy Markdown
Author

code LGTM, could you add a test for the new pricelist commission configuration?

@JordiMForgeFlow, done!

@AndreuOForgeFlow

Copy link
Copy Markdown
Author

Hi @pedrobaeza, could you please review this one and possibly merge?

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration sale_commission_pricelist_oca

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone May 19, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request May 19, 2026
7 tasks

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-677-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 231d852 into OCA:19.0 May 19, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a683680. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow
MiquelRForgeFlow deleted the 19.0-mig-sale_commission_pricelist_oca branch May 19, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.