[16.0][MIG] contract_payment_auto: Migration to 16.0#1231
Conversation
9184Lucky
force-pushed
the
16.0-mig-contract_payment_auto
branch
2 times, most recently
from
6204ed6 to
38deab5
Compare
|
/ocabot migration contract_payment_auto |
|
@9184Lucky Could you improve your commits messages in order to make module name appear in it ? Like
Moreover, if you think some can be squashed with migration one, it could be great. |
…en (OCA#167) When a contrat had no payment token but the corresponding partner had one, the transaction was created without an acquirer, leading to an integrity error in postgres. This change makes sure the token used to test the ability to pay an invoice is passed along to the transaction creation call. Tests were also added to check the ability to use the contract token if present, but the partner's in the opposite case. This change fixes OCA#165.
Currently translated at 100.0% (25 of 25 strings) Translation: contract-10.0/contract-10.0-contract_payment_auto Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_payment_auto/de/
The `_recurring_create_invoice` contract method returns multiple invoices potentially coming from different contracts, which may have different values for their `is_auto_pay` attribute. Without this patch, this case simply crashes (a unit test with more than one contract to be invoiced is a must-have in this module!).
The payment acquirer API requires an implementation of a _get_feature_support method. This is done using a temporary mock where required.
Also pass the invoice to the transaction reference computation mecanism so that it reflects the invoice's number.
This allows a cleaner overriding of _send_payment_request and improve code readability.
Initial purpose was to pass tests on a database with l10n module installed but it also simplifies the setUpClass method.
|
@rousseldenis Done ! I squashed all commit directly related to migration and fixed the other's messages. If anyone feels that some other commit should be merged feel free to asks but i think the ones I left were improvement more than migration... |
|
@9184Lucky Not yet pushed 😅 |
9184Lucky
force-pushed
the
16.0-mig-contract_payment_auto
branch
from
38deab5 to
60087a5
Compare
|
Oups ^^' |
|
@rousseldenis I pushed the new version but forgot to ping you, sorry ! |
No problem. I'll check this later today |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 639692a. Thanks a lot for contributing to OCA. ❤️ |
12 participants
No description provided.