[19.0][MIG] website_sale_secondary_unit_product_matrix: Migration to 19.0 - #1306
Open
CarlosRoca13 wants to merge 22 commits into
Open
[19.0][MIG] website_sale_secondary_unit_product_matrix: Migration to 19.0#1306CarlosRoca13 wants to merge 22 commits into
CarlosRoca13 wants to merge 22 commits into
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/it/
…n matrix although the product has 'allow_uom_sell' field to false
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/es/
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/it/
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/it/
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/es/
Weblate is not working correctly.
…injected in product matrix
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_secondary_unit_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_secondary_unit_product_matrix/it/
OCA-git-bot
added
series:19.0
mod:website_sale_secondary_unit_product_matrix
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I left a similar comment to this one: #1298 (review)
From the product list, I see an option to buy the product, which is the standard Odoo behavior.
However, on the product page, the native options are hidden (which is the purpose of this module), and the new grid is rendered.
This could be confusing for the user, since there are two different ways to buy the same product depending on where they click (from the product list or from the specific product page).
Could you add the same feature to the product list, or hide the button when the product has a secondary unit and use the grid view instead?
Contributor
Author
|
I will try to add it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT64167
This PR depends of:
ping @carlos-lopez-tecnativa @cristina-hidalgo-tecnativa