[19.0[IMP] edi_core_oca: swallow IntegrityError and malformed data errors#319
Open
yankinmax wants to merge 1 commit into
Open
[19.0[IMP] edi_core_oca: swallow IntegrityError and malformed data errors#319yankinmax wants to merge 1 commit into
yankinmax wants to merge 1 commit into
Conversation
Contributor
1 task
wouitmil
approved these changes
Jul 14, 2026
Ricardoalso
reviewed
Jul 15, 2026
Contributor
There was a problem hiding this comment.
Some time ago I added the line except (OperationalError, IntegrityError): https://github.com/OCA/edi-framework/blob/19.0/edi_core_oca/models/edi_backend.py#L266 PR #240 in order to fix failed transactions where the cursor enters an aborted state.
With this new commit we will never reach the conditional structure if res != "__sql_error__": https://github.com/OCA/edi-framework/blob/19.0/edi_core_oca/models/edi_backend.py#L282
simahawk
requested changes
Jul 21, 2026
simahawk
left a comment
simahawk
left a comment
Contributor
There was a problem hiding this comment.
I agree w/ @Ricardoalso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.