[18.0][FIX] fleet_vehicle_inspection: fix dead search filters and unsafe multi-record button_confirm - #234
Draft
CristianoMafraJunior wants to merge 2 commits into
Draft
Conversation
CristianoMafraJunior
marked this pull request as draft
September 3, 2026 17:28
Contributor
|
Hi @marcelsavegnago, |
OCA-git-bot
added
mod:fleet_vehicle_inspection_template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend #233
Summary
state/resultagainst values that never exist on those fields and therefore always returned an empty list.button_confirmsafe to call on a recordset with more than one inspection, by iterating overselfinstead of readingself.amount/self.service_type_iddirectly (which raisesValueError: Expected singleton).